New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use `cmp.Equal` instead of DeepEqual? #55722

Open
thockin opened this Issue Nov 14, 2017 · 4 comments

Comments

Projects
None yet
6 participants
@thockin
Member

thockin commented Nov 14, 2017

https://github.com/google/go-cmp/

I wonder if this can replace our semantic DeepEqual?

@lavalamp
@kubernetes/sig-api-machinery-bugs

@fejta-bot

This comment has been minimized.

Show comment
Hide comment
@fejta-bot

fejta-bot Apr 15, 2018

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

fejta-bot commented Apr 15, 2018

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@thockin

This comment has been minimized.

Show comment
Hide comment
@thockin

thockin Apr 29, 2018

Member

/lifecycle frozen
/remove-lifecycle stale

Member

thockin commented Apr 29, 2018

/lifecycle frozen
/remove-lifecycle stale

@darxtrix

This comment has been minimized.

Show comment
Hide comment
@darxtrix

darxtrix Jun 3, 2018

Hi @thockin, can I take this up ? It would be a good starter issue for me.

darxtrix commented Jun 3, 2018

Hi @thockin, can I take this up ? It would be a good starter issue for me.

@lavalamp

This comment has been minimized.

Show comment
Hide comment
@lavalamp

lavalamp Jun 4, 2018

Member
Member

lavalamp commented Jun 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment