Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
CRI: Support CRI log stats #55905
Who is using container log stats?
Who is collecting container log stats?
Cadvisor is collecting per-container log stats for docker today. See https://github.com/google/cadvisor/blob/master/container/docker/handler.go#L182.
As a temporary work around, we could point cadvisor to the container log file, as what cri-o is doing today. https://github.com/google/cadvisor/blob/master/container/crio/handler.go#L131-L138
Things need discussion
referenced this issue
Jan 8, 2018
Today In sig-node https://docs.google.com/presentation/d/1BKbTa7RBVMTjZlk_6CV5SZfV4fen3bzk5PoqiXYIUK4/edit#slide=id.g3262a28663_0_0 was discussed. With the follow 4 options:
Option 1: Point Cadvisor to the container log file to monitor container stats.
Option 2: Create a subdirectory per container and kubelet can inform cadvisor to monitor the the subdirectory to collect container stats.
Option 3: Container runtimes to support per container log stat collection
Option 4: Let kubelet monitor container log stats
I understand that these statistics are interesting to know, but I'm wondering if they need to be part of core/resource metrics at all. It feels to me this falls under normal host monitoring. I'm not sure I understand why this would need to be exposed by cAdvisor or CRI.
I don't want to get into the argument of what's core and the difference between core and Summary API, so I'll set that aside :-)
Given so, I also agree that option 4 seems to be a better option now.