New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have the Kubelet send an event when it will switch configurations #56895

Closed
mtaufen opened this Issue Dec 6, 2017 · 0 comments

Comments

Projects
None yet
2 participants
@mtaufen
Contributor

mtaufen commented Dec 6, 2017

When the Kubelet downloads a new configuration, it should send an event before restarting to use the new config. This is an important state change, and is appropriate for an event.

/cc @liggitt @mikedanese @dchen1107

@mtaufen mtaufen added this to the v1.10 milestone Dec 6, 2017

@mtaufen mtaufen self-assigned this Dec 6, 2017

@mtaufen mtaufen added the sig/node label Dec 6, 2017

k8s-merge-robot added a commit that referenced this issue Dec 21, 2017

Merge pull request #57221 from mtaufen/kc-event
Automatic merge from submit-queue (batch tested with PRs 57434, 57221, 57417, 57474, 57481). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Send an event just before the Kubelet restarts to use a new config

**What this PR does / why we need it**:
This PR makes the Kubelet send events for configuration changes. This makes it much easier to see a recent history of configuration changes for the Kubelet. 

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #56895

**Special notes for your reviewer**:

**Release note**:
```release-note
NONE
```

/cc @dchen1107 @liggitt @dashpole
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment