New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove alpha from Flex Volume docs #56920

Closed
chakri-nelluri opened this Issue Dec 7, 2017 · 11 comments

Comments

Projects
None yet
6 participants
@chakri-nelluri
Contributor

chakri-nelluri commented Dec 7, 2017

/kind bug

Flex volume docs still stay the feature is Alpha. We made it GA in Kube 1.8 time frame. We have to update the docs to reflect it.

/sig storage

@chakri-nelluri

This comment has been minimized.

Show comment
Hide comment
@chakri-nelluri

chakri-nelluri Dec 7, 2017

Contributor

@saad-ali @matchstick Can we push this change for 1.9 or it is too late?

Contributor

chakri-nelluri commented Dec 7, 2017

@saad-ali @matchstick Can we push this change for 1.9 or it is too late?

@saad-ali

This comment has been minimized.

Show comment
Hide comment
@saad-ali

saad-ali Dec 8, 2017

Member

Code freeze is lifted Monday, Dec 11 so any changes to the core kubernetes repo (this one) required for 1.9 should be in by then.

If this is purely a change to the kubernetes.io docs then we should move this issue to https://github.com/kubernetes/website/ (changes to the official kubernetes.io docs are made and tracked there.). If not, let's itemize all the required changes.

Member

saad-ali commented Dec 8, 2017

Code freeze is lifted Monday, Dec 11 so any changes to the core kubernetes repo (this one) required for 1.9 should be in by then.

If this is purely a change to the kubernetes.io docs then we should move this issue to https://github.com/kubernetes/website/ (changes to the official kubernetes.io docs are made and tracked there.). If not, let's itemize all the required changes.

@shay-berman

This comment has been minimized.

Show comment
Hide comment
@shay-berman

shay-berman Dec 9, 2017

Hi Saad and Chakri

As Chakri mentioned, FlexVolume was already GA in 1.8 but was not reflected in relevant docs.
So since its only documentation thing, try to give this issue high priority if posible so it will be part of the 1.9 release.

Thanks
Shay Berman

shay-berman commented Dec 9, 2017

Hi Saad and Chakri

As Chakri mentioned, FlexVolume was already GA in 1.8 but was not reflected in relevant docs.
So since its only documentation thing, try to give this issue high priority if posible so it will be part of the 1.9 release.

Thanks
Shay Berman

@chakri-nelluri

This comment has been minimized.

Show comment
Hide comment
@chakri-nelluri

chakri-nelluri Dec 11, 2017

Contributor

@saad-ali Verified that we need no changes from apiserver side to mark Flex GA.
Opened: kubernetes/website#6641

Contributor

chakri-nelluri commented Dec 11, 2017

@saad-ali Verified that we need no changes from apiserver side to mark Flex GA.
Opened: kubernetes/website#6641

@chakri-nelluri

This comment has been minimized.

Show comment
Hide comment
@chakri-nelluri

chakri-nelluri Dec 12, 2017

Contributor

@saad-ali Just realized the core api types have Flex as Alpha. We need a PR to fix it. If it is too late for 1.9, please feel free to target it for patch release.

Contributor

chakri-nelluri commented Dec 12, 2017

@saad-ali Just realized the core api types have Flex as Alpha. We need a PR to fix it. If it is too late for 1.9, please feel free to target it for patch release.

@saad-ali

This comment has been minimized.

Show comment
Hide comment
@saad-ali

saad-ali Dec 12, 2017

Member

Chakri could you clarify? Isn't FlexVolumeSource already part of v1 (https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/api/core/v1/types.go#L308)?

Member

saad-ali commented Dec 12, 2017

Chakri could you clarify? Isn't FlexVolumeSource already part of v1 (https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/api/core/v1/types.go#L308)?

@verult

This comment has been minimized.

Show comment
Hide comment
@verult

verult Dec 12, 2017

Contributor

Are you referring to the documentation for FlexVolumeSource here? https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/api/core/v1/types.go#L306

Update: nevermind just saw your PR. Please disregard

Contributor

verult commented Dec 12, 2017

Are you referring to the documentation for FlexVolumeSource here? https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/api/core/v1/types.go#L306

Update: nevermind just saw your PR. Please disregard

@saad-ali

This comment has been minimized.

Show comment
Hide comment
@saad-ali

saad-ali Dec 12, 2017

Member

Ah ok! I would support change this documentation (updating comment on v1 FlexVolumeSource) for 1.9 to drop alpha wording. Please reach out to the release team to see if they will allow this change (since it is just a documentation change it is very low risk).

Member

saad-ali commented Dec 12, 2017

Ah ok! I would support change this documentation (updating comment on v1 FlexVolumeSource) for 1.9 to drop alpha wording. Please reach out to the release team to see if they will allow this change (since it is just a documentation change it is very low risk).

@saad-ali

This comment has been minimized.

Show comment
Hide comment
@saad-ali

saad-ali Dec 12, 2017

Member

I will mark it for 1.9, the release team can choose to remove it if it is too late.

Member

saad-ali commented Dec 12, 2017

I will mark it for 1.9, the release team can choose to remove it if it is too late.

@saad-ali saad-ali changed the title from Update Flex volume docs to represent it i to Remove alpha from Flex Volume docs Dec 12, 2017

@saad-ali saad-ali added this to the v1.9 milestone Dec 12, 2017

@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Dec 12, 2017

Contributor

[MILESTONENOTIFIER] Milestone Issue Current

@chakri-nelluri

Note: This issue is marked as priority/critical-urgent, and must be updated every 1 day during code freeze.

Example update:

ACK.  In progress
ETA: DD/MM/YYYY
Risks: Complicated fix required
Issue Labels
  • sig/storage: Issue will be escalated to these SIGs if needed.
  • priority/critical-urgent: Never automatically move issue out of a release milestone; continually escalate to contributor and SIG through all available channels.
  • kind/bug: Fixes a bug discovered during the current release.
Help
Contributor

k8s-merge-robot commented Dec 12, 2017

[MILESTONENOTIFIER] Milestone Issue Current

@chakri-nelluri

Note: This issue is marked as priority/critical-urgent, and must be updated every 1 day during code freeze.

Example update:

ACK.  In progress
ETA: DD/MM/YYYY
Risks: Complicated fix required
Issue Labels
  • sig/storage: Issue will be escalated to these SIGs if needed.
  • priority/critical-urgent: Never automatically move issue out of a release milestone; continually escalate to contributor and SIG through all available channels.
  • kind/bug: Fixes a bug discovered during the current release.
Help

k8s-merge-robot added a commit that referenced this issue Dec 12, 2017

Merge pull request #57075 from chakri-nelluri/flex-ga
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Mark Flexvolume as GA

Flex volume became GA from release 1.8 onwards. This PR fixes the comments to reflect it.

Fixes #56920 

**Special notes for your reviewer**:

**Release note**:
```release-note
Flexvolume feature has graduated to GA.
```
@shay-berman

This comment has been minimized.

Show comment
Hide comment
@shay-berman

shay-berman Dec 13, 2017

@chakri-nelluri and @saad-ali thanks for making it happened in k8s 1.9 time frame! Really appreciate your responsiveness.

Consider to open a ticket to patch k8s 1.8 as well with FlexVolume as v1. As mentioned above it was already marked as v1 in 1.8 time frame.

Thanks

shay-berman commented Dec 13, 2017

@chakri-nelluri and @saad-ali thanks for making it happened in k8s 1.9 time frame! Really appreciate your responsiveness.

Consider to open a ticket to patch k8s 1.8 as well with FlexVolume as v1. As mentioned above it was already marked as v1 in 1.8 time frame.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment