New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PodNodeSelector and PodTolerationRestriction feature status is unclear #57424

Closed
ericchiang opened this Issue Dec 19, 2017 · 13 comments

Comments

Projects
None yet
9 participants
@ericchiang
Copy link
Member

ericchiang commented Dec 19, 2017

/kind bug

@kubernetes/sig-scheduling-bugs

Newer admission controllers generally call out when they're alpha/beta. While PodNodeSelector and PodTolerationRestriction don't have an explicit status, they rely on alpha annotations.

https://kubernetes.io/docs/admin/admission-controllers/

scheduler.alpha.kubernetes.io/node-selector
scheduler.alpha.kubernetes.io/defaultTolerations
scheduler.alpha.kubernetes.io/tolerationsWhitelist

Are these alpha features? I've seen them come up a lot lately, particularly in the context of multitenancy and devoted nodes.

https://docs.google.com/document/d/1jAcsC4sLgEV9__TdgJrMvPa3G73G62tFtMcKQgeIlHM/edit#

@resouer

This comment has been minimized.

Copy link
Member

resouer commented Dec 20, 2017

@ericchiang The last two are introduced in #30302 and does not follow alpha feature practices (or probably too early when there're no such practices ).

The first one is even earlier #24980

We may need to move them to well_known_labels, and also make them GA, and fix their names since they actually hits #51246 ...

@ericchiang

This comment has been minimized.

Copy link
Member

ericchiang commented Jan 18, 2018

@colemickens has volunteered to take this.

/assign @colemickens

@embano1

This comment has been minimized.

Copy link

embano1 commented Jan 19, 2018

Agree with @ericchiang that this is confusing at the moment. Reading Extensible Admission is Beta confused me when I read the code on PodNodeSelector

// The annotation key scheduler.alpha.kubernetes.io/node-selector is for assigning
// node selectors labels to namespaces
var NamespaceNodeSelectors = []string{"scheduler.alpha.kubernetes.io/node-selector"}

https://github.com/kubernetes/kubernetes/blob/v1.9.2/plugin/pkg/admission/podnodeselector/admission.go#L41

Glad this is being tracked.

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Jan 25, 2018

  • Should probably drop the alpha from the annotations and include in well known annotations constants
  • Also need to update the admission plugin config to read from a versioned config object
@wackxu

This comment has been minimized.

Copy link
Contributor

wackxu commented Jan 25, 2018

@liggitt I can help do it. Can you take a look at #58198

@colemickens

This comment has been minimized.

Copy link
Contributor

colemickens commented Jan 25, 2018

Hey @wackxu I'm working on this right now. Just a heads up.

@wackxu

This comment has been minimized.

Copy link
Contributor

wackxu commented Jan 25, 2018

Should probably drop the alpha from the annotations and include in well known annotations constants
Also need to update the admission plugin config to read from a versioned config object

@colemickens Hi, The second I have done almost half work, Can I continue on the second and the first you can continue working on.

@colemickens

This comment has been minimized.

Copy link
Contributor

colemickens commented Jan 25, 2018

Sounds great. Thanks @wackxu!

@colemickens

This comment has been minimized.

Copy link
Contributor

colemickens commented Feb 24, 2018

@wackxu I forgot we had discussed this. The PRs I have open for PNS/PTR (#60284, #60285) have the versioned config changes (and tests) included.

@colemickens

This comment has been minimized.

Copy link
Contributor

colemickens commented Mar 1, 2018

/sig scheduling

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented May 30, 2018

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Jun 29, 2018

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Jul 30, 2018

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment