New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSI - fsType is not being passed to driver #58183

Closed
vladimirvivien opened this Issue Jan 12, 2018 · 2 comments

Comments

Projects
None yet
4 participants
@vladimirvivien
Member

vladimirvivien commented Jan 12, 2018

/kind bug

What happened:
Unable to specify fsType from a CSI PV. The fsType is currently hardcoded to ext4.

What you expected to happen:
Being able to specify fsType when creating a CSI PV

apiVersion: v1
kind: PersistentVolume
metadata:
  name: manually-created-pv
spec:
  capacity:
    storage: 5Gi
  accessModes:
    - ReadWriteOnce
  persistentVolumeReclaimPolicy: Retain
  csi:
    driver: com.example.team/csi-driver
    volumeHandle: existingVolumeName
    readOnly: false
    fsType: ext4

@vladimirvivien vladimirvivien changed the title from CSI Internal: fsType is not being passed to driver to CSI - fsType is not being passed to driver Jan 12, 2018

@NickrenREN

This comment has been minimized.

Show comment
Hide comment
@NickrenREN

NickrenREN Jan 12, 2018

Member

/assign

Member

NickrenREN commented Jan 12, 2018

/assign

@liggitt

This comment has been minimized.

Show comment
Hide comment
@liggitt

liggitt Jan 14, 2018

Member

/sig storage

Member

liggitt commented Jan 14, 2018

/sig storage

@k8s-ci-robot k8s-ci-robot added sig/storage and removed needs-sig labels Jan 14, 2018

@liggitt liggitt added kind/enhancement and removed kind/bug labels Jan 14, 2018

k8s-merge-robot added a commit that referenced this issue Jan 18, 2018

Merge pull request #58209 from NickrenREN/csi-fstype
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Add FSType for CSI volume source

**What this PR does / why we need it**:
Add FSType for CSI volume source to specify filesystems (alpha defaults to `ext4`)

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #58183

**Special notes for your reviewer**:

**Release note**:
```release-note
Add FSType for CSI volume source to specify filesystems
```

/assign @saad-ali 
cc @vladimirvivien
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment