Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
In some admission plugins Validate is called twice #58196
Is this a BUG REPORT or FEATURE REQUEST?:
I think this is a redundant work
What you expected to happen:
Validate be called only once, in validating stage.
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
this is not a bug, it is an intentional factoring.
during the Admit phase, these plugins do some mutation and some validation. if the validation fails, we want to reject early.
during the Validate phase, they recheck that the result is still valid (and hasn't been invalidated by other things in the Admit phase)