Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve k8s support for multizone PDs. #59988

Closed
verult opened this Issue Feb 16, 2018 · 7 comments

Comments

Projects
None yet
5 participants
@verult
Copy link
Contributor

verult commented Feb 16, 2018

/kind feature

  • Add more e2e tests for multizone PDs.
  • Align with ongoing volume topology work.

/sig storage
/assign

k8s-github-robot pushed a commit that referenced this issue Feb 24, 2018

Kubernetes Submit Queue
Merge pull request #60165 from verult/repd-beta
Automatic merge from submit-queue (batch tested with PRs 59286, 59743, 59883, 60190, 60165). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Updating GCE PD StorageClass parameters

**What this PR does / why we need it**: New parameter to improve support of multi-zone PDs.

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: partially addresses #59988

/cc @msau42 @saad-ali

k8s-github-robot pushed a commit that referenced this issue Feb 24, 2018

Kubernetes Submit Queue
Merge pull request #59990 from verult/pd-alpha
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

e2e tests for multizone PDs

**What this PR does / why we need it**: e2e tests for multizone PDs.

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
partially fixing #59988

/release-note-none

/assign @msau42 @saad-ali

@saad-ali saad-ali added this to the v1.10 milestone Feb 27, 2018

heckj pushed a commit to heckj/kubernetes that referenced this issue Feb 27, 2018

Kubernetes Submit Queue
Merge pull request kubernetes#60337 from verult/repd-feature-gate
Automatic merge from submit-queue (batch tested with PRs 60157, 60337, 60246, 59714, 60467). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Feature gate for regional PDs

**What this PR does / why we need it**: Adding beta feature gate around regional PD support.

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Partially addresses kubernetes#59988

**Special notes for your reviewer**: This feature has already been in alpha for two releases, but at the time it was not gated with a Kubernetes feature gate. Instead it was controlled by a GCE-specific alpha gate. However, there are additional changes with GCE PD StorageClass parameters that we'd like to gate as well, and this is out of scope of GCE alpha gates.

/cc @saad-ali @lavalamp
@jberkus

This comment has been minimized.

Copy link

jberkus commented Feb 28, 2018

@saad-ali @verult in order for this issue to stay in 1.10 it needs a status/approved-for-milestone label from the SIG. Please add one if you expect to resolve this issue in the next few days, or if the issue is a blocker for 1.10 release.

@jberkus

This comment has been minimized.

Copy link

jberkus commented Mar 5, 2018

Given the lack of responsiveness, this feature issue will be removed from 1.10 in 24 hours unless updated.

@verult

@verult

This comment has been minimized.

Copy link
Contributor Author

verult commented Mar 5, 2018

Apologies for the delayed response. The last outstanding PR is #60450, which depends on a Go client that is currently in the process of being rolled out. Expect integration to be complete by this Friday, 3/9.

Also requested the status/approved-for-milestone label.

@saad-ali

This comment has been minimized.

Copy link
Member

saad-ali commented Mar 5, 2018

@saad-ali saad-ali added this to the v1.10 milestone Mar 5, 2018

@verult

This comment has been minimized.

Copy link
Contributor Author

verult commented Mar 6, 2018

ACK. In progress
ETA: 3/9/2018

@verult

This comment has been minimized.

Copy link
Contributor Author

verult commented Mar 8, 2018

The dependency has been updated. #60450 ready for review, and I'm running e2e tests in parallel.
ETA: 3/9/2018

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented Mar 8, 2018

[MILESTONENOTIFIER] Milestone Issue: Up-to-date for process

@verult

Note: This issue is marked as priority/critical-urgent, and must be updated every 1 day during code freeze.

Example update:

ACK.  In progress
ETA: DD/MM/YYYY
Risks: Complicated fix required
Issue Labels
  • sig/gcp sig/storage: Issue will be escalated to these SIGs if needed.
  • priority/critical-urgent: Never automatically move issue out of a release milestone; continually escalate to contributor and SIG through all available channels.
  • kind/feature: New functionality.
Help

k8s-github-robot pushed a commit that referenced this issue Mar 9, 2018

Kubernetes Submit Queue
Merge pull request #60450 from verult/repd-beta-integration
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Change regional PD cloud provider references to use the beta API

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #59988

**Special notes for your reviewer**: Depends on a version of the GCP Go beta compute client that is not yet available. Also need to rebase with #60337 once it's merged.

/hold
/cc @abgworrall 
/assign @saad-ali

k8s-github-robot pushed a commit that referenced this issue May 24, 2018

Kubernetes Submit Queue
Merge pull request #64223 from verult/e2e-repd-regsuite
Automatic merge from submit-queue (batch tested with PRs 64174, 64187, 64216, 63265, 64223). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Moving Regional PD e2e tests to regular test suites

**What this PR does / why we need it**: Regional PD e2e tests previously only run on alpha suites. Need to move them to the regular test suites

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Part of #59988

**Special notes for your reviewer**: Will be cherry-picked to 1.10 once merged.

**Release note**:

```release-note
NONE
```
/sig gcp
/sig storage
/assign @msau42 @saad-ali

k8s-github-robot pushed a commit that referenced this issue May 31, 2018

Kubernetes Submit Queue
Merge pull request #64480 from verult/repd-ig-fix
Automatic merge from submit-queue (batch tested with PRs 62460, 64480, 63774, 64540, 64337). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Modified regional PD test to fetch template name from GCE

**What this PR does / why we need it**: Previously, the regional PD failover e2e test assumes a specific relationship between the names of an instance group and its corresponding template. It turns out to not always hold true for different types of clusters. Instead, the test should fetch the correct template name by calling out to GCE.

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Part of #59988

Need to cherry pick this back to 1.10 along with #64223 

**Release note**:

```release-note
NONE
```

/assign @saad-ali @wojtek-t 
/sig storage

jingxu97 added a commit to jingxu97/kubernetes that referenced this issue Nov 6, 2018

jingxu97 added a commit to jingxu97/kubernetes that referenced this issue Nov 6, 2018

jingxu97 added a commit to jingxu97/kubernetes that referenced this issue Nov 7, 2018

goodluckbot added a commit to goodluckbot/kubernetes that referenced this issue Nov 11, 2018

phenixblue added a commit to phenixblue/kubernetes that referenced this issue Jan 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.