New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Memory/Disk pressure predicates if TaintNodesByCondition enabled #60397

Closed
k82cn opened this Issue Feb 26, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@k82cn
Member

k82cn commented Feb 26, 2018

Is this a BUG REPORT or FEATURE REQUEST?:

/kind bug

Description:

If TaintNodesByCondition enabled, we should disable CheckNodeMemoryPressure and CheckDiskPressure predicates in scheduler. In TaintNodeByCondition, we will handle those conditions: NetworkUnavailable, MemoryPressure, OutOfDisk and DiskPressure; NetworkUnavailable checking is removed by CheckNodeCondition predicates, but MemoryPressure and DiskPressure not (no predicate for OutOfDisk).

/cc @bsalamat @gmarek

@k82cn

This comment has been minimized.

Member

k82cn commented Feb 26, 2018

/sig scheduling
/sig node

@k82cn

This comment has been minimized.

Member

k82cn commented Feb 26, 2018

/assign

k8s-merge-robot added a commit that referenced this issue Apr 4, 2018

Merge pull request #60398 from k82cn/k8s_60397
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Disabled MemoryPressure and DiskPressure predicates if TaintNodesByCondition enabled

Signed-off-by: Da K. Ma <madaxa@cn.ibm.com>


**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #60397 

**Release note**:

```release-note
Disabled CheckNodeMemoryPressure and CheckNodeDiskPressure predicates if TaintNodesByCondition enabled
```

@k82cn k82cn referenced this issue Apr 19, 2018

Open

Upgrade TaintNodesByCondition to Beta #62109

13 of 15 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment