Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1: CustomResourceColumnDefinition JSONPath should be serialized as "jsonPath" #66531

Closed
tatsuhiro-t opened this issue Jul 24, 2018 · 11 comments

Comments

@tatsuhiro-t
Copy link
Contributor

commented Jul 24, 2018

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:

/kind bug

/kind feature

What happened:

CustomResoruceColumnDefinition JSONPath is serialized as "JSONPath".
All fields I observed start with lower case letter, regardless they are abbreviated name (e.g., osImage, nfs). JSONPath is inconsistent to the rest of the API object serialization. Not sure there is a rule for this, or some exceptions.

What you expected to happen:

JSONPath should be serialized as "jsonPath".

How to reproduce it (as minimally and precisely as possible):

https://godoc.org/k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1beta1#CustomResourceColumnDefinition

Anything else we need to know?:

Environment:

  • Kubernetes version (use kubectl version):
Client Version: version.Info{Major:"1", Minor:"11", GitVersion:"v1.11.0", GitCommit:"91e7b4fd31fcd3d5f436da26c980becec37ceefe", GitTreeState:"clean", BuildDate:"2018-06-27T20:17:28Z", GoVersion:"go1.10.2", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"11", GitVersion:"v1.11.1", GitCommit:"b1b29978270dc22fecc592ac55d903350454310a", GitTreeState:"clean", BuildDate:"2018-07-17T18:43:26Z", GoVersion:"go1.10.3", Compiler:"gc", Platform:"linux/amd64"}
  • Cloud provider or hardware configuration:
  • OS (e.g. from /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:
@tatsuhiro-t

This comment has been minimized.

Copy link
Contributor Author

commented Jul 24, 2018

/sig api-machinery

@liggitt

This comment has been minimized.

Copy link
Member

commented Jul 24, 2018

/assign @sttts @nikhita

@liggitt

This comment has been minimized.

Copy link
Member

commented Jul 24, 2018

this won't change in v1beta1, but can be corrected in v1

@sttts

This comment has been minimized.

Copy link
Contributor

commented Jul 24, 2018

We had a discussion about that when introducing the types and decided for JSONPath. I don't feel strongly about either way. I believe to remember @smarterclayton wanted the upper case one.

@smarterclayton

This comment has been minimized.

Copy link
Contributor

commented Jul 24, 2018

I did? All api fields should start with lowercase and be camelCase, so if I said that it was wrong

@liggitt

This comment has been minimized.

Copy link
Member

commented Jul 24, 2018

yeah, needs to be on the list for v1 fixup

@nikhita

This comment has been minimized.

Copy link
Member

commented Jul 24, 2018

/area custom-resources

@sttts

This comment has been minimized.

Copy link
Contributor

commented Jul 25, 2018

@smarterclayton maybe I wrongly blame you and it was just a misunderstanding. v1 fixup sounds good.

@fedebongio

This comment has been minimized.

Copy link
Contributor

commented Jul 30, 2018

/cc @mbohlool

@nikhita nikhita referenced this issue Aug 11, 2018
27 of 54 tasks complete
@fejta-bot

This comment has been minimized.

Copy link

commented Oct 28, 2018

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@nikhita

This comment has been minimized.

Copy link
Member

commented Oct 29, 2018

Going to add lifecycle/frozen because this won't be handled until v1.

/lifecycle frozen

@liggitt liggitt moved this from Triage to Required for GA, not started in Custom Resource Definitions Apr 18, 2019
@liggitt liggitt changed the title CustomResourceColumnDefinition JSONPath should be serialized as "jsonPath" v1: CustomResourceColumnDefinition JSONPath should be serialized as "jsonPath" Apr 24, 2019
@liggitt liggitt added this to the v1.16 milestone Jun 12, 2019
@liggitt liggitt moved this from Required for GA, not started to Required for GA, in progress in Custom Resource Definitions Jul 1, 2019
@liggitt liggitt moved this from Required for GA, in progress to Complete in Custom Resource Definitions Aug 17, 2019
@liggitt liggitt closed this Aug 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.