New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add proxy disable support in http liveness probe #68607

Open
WanLinghao opened this Issue Sep 13, 2018 · 3 comments

Comments

Projects
None yet
3 participants
@WanLinghao
Contributor

WanLinghao commented Sep 13, 2018

/kind feature

Currently the liveness probe in container will use node's local proxy settings by default.
For example, if the node has environment set like: http_proxy=xxxx, the http liveness probe will use this proxy. But I think for most situation, the proxy is not set to do liveness probe. This would cause liveness probe failure which should not.
So I think we need provide a way for users to choose if the http liveness probe should use node's local proxy settings.

@WanLinghao WanLinghao changed the title from add disable proxy support in http liveness probe to add proxy disable support in http liveness probe Sep 13, 2018

@WanLinghao

This comment has been minimized.

Show comment
Hide comment
@WanLinghao

WanLinghao Sep 13, 2018

Contributor

/assign

Contributor

WanLinghao commented Sep 13, 2018

/assign

@shubheksha

This comment has been minimized.

Show comment
Hide comment
@shubheksha

shubheksha Sep 13, 2018

Contributor

/sig network

Contributor

shubheksha commented Sep 13, 2018

/sig network

@k8s-ci-robot k8s-ci-robot added sig/network and removed needs-sig labels Sep 13, 2018

@WanLinghao

This comment has been minimized.

Show comment
Hide comment
@WanLinghao

WanLinghao Sep 14, 2018

Contributor

ref:#68663

Contributor

WanLinghao commented Sep 14, 2018

ref:#68663

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment