New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

options.ServerRunOptions are used only in kube-apiserver #68658

Open
MikeSpreitzer opened this Issue Sep 14, 2018 · 3 comments

Comments

Projects
None yet
5 participants
@MikeSpreitzer
Collaborator

MikeSpreitzer commented Sep 14, 2018

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:

/kind bug
/kind feature

What happened:
Colleagues made an extension apiserver based on the sample. I stressed it, and ran up against server.Config.MaxMutatingRequestsInFlight. I tried to up that limit with a command line flag, then discovered that the extension server does not support the standard flag for that. The standard support is in https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apiserver/pkg/server/options/server_run_options.go and is used by neither the generic apiserver package nor the sample extension server.

What you expected to happen:
I expected to be able to control the extension server's concurrency limits with command line flags.

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:
I found this in release 1.10, and the problem remains in master.

Environment:

  • Kubernetes version (use kubectl version):
  • Cloud provider or hardware configuration:
  • OS (e.g. from /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:
@MikeSpreitzer

This comment has been minimized.

Show comment
Hide comment
Collaborator

MikeSpreitzer commented Sep 14, 2018

@yue9944882

This comment has been minimized.

Show comment
Hide comment
@yue9944882

yue9944882 Sep 14, 2018

Contributor

/cc

Contributor

yue9944882 commented Sep 14, 2018

/cc

@wenjiaswe

This comment has been minimized.

Show comment
Hide comment
@wenjiaswe

wenjiaswe Sep 17, 2018

Contributor

/assign @cheftako

Contributor

wenjiaswe commented Sep 17, 2018

/assign @cheftako

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment