Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sig-apps] Daemon set [Serial] should not update pod when spec was updated and update strategy is OnDelete #69356

Closed
jberkus opened this Issue Oct 3, 2018 · 11 comments

Comments

Projects
None yet
6 participants
@jberkus
Copy link

commented Oct 3, 2018

DaemonSet upgrades and downgrades have been failing since 9/25.

Dashboard: https://k8s-testgrid.appspot.com/sig-release-master-upgrade#gce-new-master-upgrade-master

Sample Failure: https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/logs/ci-kubernetes-e2e-gce-new-master-upgrade-master/1803

This test failure will block 1.13 beta, so please let's fix it before then. Thanks!

/sig apps
/kind failing-test
/priority important-soon

@mortent

This comment has been minimized.

Copy link
Member

commented Oct 3, 2018

I'm investigating this.
It is related to the change here: #68754. Still figuring out the actual impact and how to fix it.

@jberkus

This comment has been minimized.

Copy link
Author

commented Oct 3, 2018

@mortent mortent referenced this issue Oct 3, 2018

Closed

REQUEST: New membership for mortent #136

6 of 6 tasks complete
@mortent

This comment has been minimized.

Copy link
Member

commented Oct 3, 2018

/assign

@AishSundar

This comment has been minimized.

Copy link
Contributor

commented Oct 7, 2018

FWIW there's one more related test failure - #67903

@bradhoekstra

This comment has been minimized.

Copy link
Contributor

commented Oct 18, 2018

This is also being discussed in this issue: #69445

@bradhoekstra

This comment has been minimized.

Copy link
Contributor

commented Oct 19, 2018

Any opinions on whether the suggestion by @kow3ns here is the correct approach for fixing this?

@jberkus

This comment has been minimized.

Copy link
Author

commented Oct 23, 2018

I'm escalating this issue to critical-urgent.

At this point, not resolving this is keeping us from verifying the upgrade tests. Because the Daemonsets have been failing for weeks, at this point we don't know what other upgrade test job failures that may be masking, and whether any of the other test flakes are related to the Daemonset failure. This needs to be resolved, ASAP.

/priority critical-urgent

@jberkus

This comment has been minimized.

Copy link
Author

commented Oct 23, 2018

/remove-priority important-soon

@AishSundar

This comment has been minimized.

Copy link
Contributor

commented Oct 23, 2018

@jberkus #69988 which just merged claims to fix this issue. lets watch for the next run.

@nikopen

This comment has been minimized.

Copy link
Member

commented Oct 24, 2018

DaemonSet tests passed on run 1842, seems to have been fixed: https://k8s-testgrid.appspot.com/sig-release-master-upgrade#gce-new-master-upgrade-master

if it doesn't pop up again -

/close

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Oct 24, 2018

@nikopen: Closing this issue.

In response to this:

DaemonSet tests passed on run 1842, seems to have been fixed: https://k8s-testgrid.appspot.com/sig-release-master-upgrade#gce-new-master-upgrade-master

if it doesn't pop up again -

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.