New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fake_event_expansion / fake_node_expansion do not expose PatchType. #69632

Open
vaikas-google opened this Issue Oct 10, 2018 · 3 comments

Comments

Projects
None yet
3 participants
@vaikas-google
Contributor

vaikas-google commented Oct 10, 2018

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:

/kind bug
/kind feature

What happened:
kubernetes/pkg/client/clientset_generated/internalclientset/typed/core/internalversion/fake/fake_event_expansion.go
kubernetes/pkg/client/clientset_generated/internalclientset/typed/core/internalversion/fake/fake_node_expansion.go

do not support PatchType. They probably should.

What you expected to happen:
These files are not auto-generated, nor do they support PatchType.

How to reproduce it (as minimally and precisely as possible):
delete these two files, run autogen, see they do not come back. Also, their API does not include patch type.

@caesarxuchao

This comment has been minimized.

Show comment
Hide comment
@caesarxuchao

caesarxuchao Oct 10, 2018

Member

/assign

Member

caesarxuchao commented Oct 10, 2018

/assign

@caesarxuchao

This comment has been minimized.

Show comment
Hide comment
@caesarxuchao

caesarxuchao Oct 10, 2018

Member

/kind cleanup
/sig api-machinery
See #69330 (comment).

Member

caesarxuchao commented Oct 10, 2018

/kind cleanup
/sig api-machinery
See #69330 (comment).

@vaikas-google

This comment has been minimized.

Show comment
Hide comment
@vaikas-google

vaikas-google Oct 10, 2018

Contributor

/kind bug

Contributor

vaikas-google commented Oct 10, 2018

/kind bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment