Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Proposal: Move k8s.io/apimachinery/pkg/apis/meta/v1 to k8s.io/api/meta #69653
Is this a BUG REPORT or FEATURE REQUEST?:
I was looking through the the deployment example as I'd like to generate JSON templates that I can pipe into
There's a few issues I've encountered;
The intended PR would be moving the meta struct from apimachinery to
It would look like this;
Anything else we need to know?:
referenced this issue
Oct 11, 2018
This would cause the import direction to be wrong (apimachinery can't import the entire api), so we can't change this.
Removing glog as a dep from apimachinery I'm 100% on board with and will LGTM PRs that replace it with something else or isolate it somehow :)
Would api machinery need to import the entire API? It seems only dependent on meta and some of the primitive types. I guess I don’t have enough of an understanding of how it works though. To work around it I’ve copy+pasted the packages where I’m currently using them and ripped out glog where I encountered it. Will paste a public repo when I’m at my laptop to provide a concrete implementation to reference. What’s apimachinery’s primary role? Generating structs from protobufs? The README cites: “Scheme, typing, encoding, decoding, and conversion packages for Kubernetes and Kubernetes-like API objects.” I tried building k8s from a clone but had some errors with “bazel build //...”. Didn’t really investigate bc it was getting late yesterday. In terms of glog it looks like it gets pulled in as a result of logging in some of the primitive type parsing think intstr was one of the packages. I’m not sure if it’s code generated by protobuf but seems related.