Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing test: [sig-autoscaling] [HPA] Horizontal pod autoscaling (scale resource: CPU) [sig-autoscaling] [Serial] [Slow] ReplicationController Should scale from 1 pod to 3 pods and from 3 to 5 and verify decision stabilityChanges #70655

Closed
mariantalla opened this Issue Nov 5, 2018 · 9 comments

Comments

Projects
None yet
5 participants
@mariantalla

This comment has been minimized.

Copy link
Contributor Author

mariantalla commented Nov 5, 2018

/sig autoscaling

@AishSundar

This comment has been minimized.

Copy link
Contributor

AishSundar commented Nov 7, 2018

@jbartosik this failure is currently blocking Beta for 1..13. Can you please investigate these and let us know the path forward.

@jbartosik

This comment has been minimized.

Copy link
Contributor

jbartosik commented Nov 7, 2018

It looks like it's the same problem (too strict expectations of the test) I'm solving in issue #69444 manifesting in test going in other direction so those PRs should solve it (both tests use the same helper to set expectations so relaxing expectations of the helper should help both tests).

This is an issue with tests having too strict expectations, I wouldn't block a release on it.

@AishSundar

This comment has been minimized.

Copy link
Contributor

AishSundar commented Nov 7, 2018

@jbartosik just to be clear the CPs above should fix this too or is there a new PR to relax the strict expectation?

@jbartosik jbartosik referenced this issue Nov 7, 2018

Closed

REQUEST: New membership for jbartosik #225

6 of 6 tasks complete
@jbartosik

This comment has been minimized.

Copy link
Contributor

jbartosik commented Nov 7, 2018

The PRs above are relaxing tests. They should fix this issue.

@jberkus

This comment has been minimized.

Copy link

jberkus commented Nov 12, 2018

Unable to verify that the fix worked, because the test is failing for unrelated reasons.

@AishSundar

This comment has been minimized.

Copy link
Contributor

AishSundar commented Nov 14, 2018

I see these 2 pass in the latest run of https://k8s-testgrid.appspot.com/sig-release-master-upgrade#gce-new-master-upgrade-master (after we split out the parallel and non-parallel runs).

Over to @jberkus to close when he sees fit

@jberkus

This comment has been minimized.

Copy link

jberkus commented Nov 14, 2018

/close

Thanks @jbartosik for the long slog!

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 14, 2018

@jberkus: Closing this issue.

In response to this:

/close

Thanks @jbartosik for the long slog!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.