New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question][client-go/tools/cache] DeltaFIFO.List() copy requirement #70751

Open
Adirio opened this Issue Nov 7, 2018 · 2 comments

Comments

Projects
None yet
4 participants
@Adirio
Contributor

Adirio commented Nov 7, 2018

Current situations:

DeltaFIFO.List() is making a swallow copy of each slice in DeltaFIFO.items and then calling their Newest() method, which returns the last element (which is not copied as it was a swallow copy).

Question:

Does this method require a deep copy or can the swallow copy just be removed?

/kind cleanup

@neolit123

This comment has been minimized.

Member

neolit123 commented Nov 8, 2018

/sig api-machinery

@fedebongio

This comment has been minimized.

Contributor

fedebongio commented Nov 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment