New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

healthz checker test doesn't test what it should #70752

Closed
logicalhan opened this Issue Nov 7, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@logicalhan
Contributor

logicalhan commented Nov 7, 2018

What happened:

The logic in the checkerNames test for healthz_test is faulty. Failing the test when the 'wanted' value equals the actual result is the opposite behavior of what we want.

What you expected to happen:

I expect the test to fail when the desired output is not the same as the actual output.

/kind bug

@logicalhan

This comment has been minimized.

Contributor

logicalhan commented Nov 7, 2018

/sig api-machinery
/assign @logicalhan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment