New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage e2e tests: setting --delete-namespace-on-failure=false should prevent deletion of test pods, PVCs, etc. #70777

Open
verult opened this Issue Nov 8, 2018 · 0 comments

Comments

Projects
None yet
2 participants
@verult
Contributor

verult commented Nov 8, 2018

Setting --delete-namespace-on-failure=false is often used to keep objects in test running when the failure occurs, to help with debugging. However, many storage e2e tests, including CSI tests, clean up test pods and PVCs in a defer statement and AfterEach. As a result, even if the flag is set to false, everything gets cleaned up anyway.

One option is to put cleanup functions at the end of each test, as regular function calls rather than deferred calls, but this defeats the purpose of AfterEach.

What we might need is a --cleanup-on-failureflag that enables/disablesAfterEach`

/priority important-longterm
/sig storage
/sig testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment