New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update heketi dependency after licensing issues are fixed #70802

Closed
dims opened this Issue Nov 8, 2018 · 11 comments

Comments

Projects
None yet
6 participants
@dims
Member

dims commented Nov 8, 2018

Please see discussion in:

Once things are fixed we need to update k/k with latest from heketi repo

Alternative : Drop GlusterFS in-tree plugin

@dims

This comment has been minimized.

Member

dims commented Nov 8, 2018

/milestone v1.13

@k8s-ci-robot k8s-ci-robot added this to the v1.13 milestone Nov 8, 2018

@dims

This comment has been minimized.

Member

dims commented Nov 8, 2018

/sig release
/priority important-soon

@dims

This comment has been minimized.

Member

dims commented Nov 8, 2018

@justaugustus

This comment has been minimized.

Member

justaugustus commented Nov 8, 2018

Bumping the priority on this, given the discussion in #sig-architecture.
/priority critical-urgent

@justaugustus

This comment has been minimized.

Member

justaugustus commented Nov 8, 2018

/remove-priority important-soon

@AishSundar

This comment has been minimized.

Contributor

AishSundar commented Nov 8, 2018

/kind cleanup

/assign @childsb
/cc @erinboyd @humblec

@AishSundar

This comment has been minimized.

Contributor

AishSundar commented Nov 8, 2018

/cc @nikopen

@nikopen this is a critical issue we are tracking for 1.13.

@nikopen

This comment has been minimized.

Member

nikopen commented Nov 8, 2018

ack, I've read the background.

Should expect the new version to go in by early next week so there's some days between it and code freeze for CI.

obnoxxx added a commit to obnoxxx/heketi that referenced this issue Nov 8, 2018

pkg/utils: relicense to dual Apache2 and LGPLv3+
In a sequence of commits

fc8e4c5
31b83a8
7c3cd4c

Heketi was relicensed from Apache to the following model:

- the rest api client code is under dual Apache2 or LGPLv3+
- all other parts (server, cli, tests, ...) are under dual LGPLv3+ or GPLv2

Now an oversight/mistake was made in that parts of the pkg/utils are
used in the client and hence apache-licensed projects that compile
in heketi client, like kubernetes, have a license problem since they
pull GPL code in. See:

heketi#1279
kubernetes/kubernetes#35557
kubernetes/kubernetes#70802

This patch fixes the oversight by relicensing the remaining
pieces of pkg/utils to the same dual Apache2 or LGPLv3+ license
after those parts that are only used in the server have been
moved out of pkg/utils.

Resolves: heketi#1279

Signed-off-by: Michael Adam <obnox@redhat.com>
Signed-off-by: John Mulligan <jmulligan@redhat.com>

obnoxxx added a commit to heketi/heketi that referenced this issue Nov 9, 2018

pkg/utils: relicense to dual Apache2 and LGPLv3+
In a sequence of commits

fc8e4c5
31b83a8
7c3cd4c

Heketi was relicensed from Apache to the following model:

- the rest api client code is under dual Apache2 or LGPLv3+
- all other parts (server, cli, tests, ...) are under dual LGPLv3+ or GPLv2

Now an oversight/mistake was made in that parts of the pkg/utils are
used in the client and hence apache-licensed projects that compile
in heketi client, like kubernetes, have a license problem since they
pull GPL code in. See:

#1279
kubernetes/kubernetes#35557
kubernetes/kubernetes#70802

This patch fixes the oversight by relicensing the remaining
pieces of pkg/utils to the same dual Apache2 or LGPLv3+ license
after those parts that are only used in the server have been
moved out of pkg/utils.

Resolves: #1279

Signed-off-by: Michael Adam <obnox@redhat.com>
Signed-off-by: John Mulligan <jmulligan@redhat.com>
@AishSundar

This comment has been minimized.

Contributor

AishSundar commented Nov 9, 2018

heketi/heketi#1279 is now closed. @childsb we should be good to pull the changes into k/k right?

@AishSundar

This comment has been minimized.

Contributor

AishSundar commented Nov 9, 2018

ah I see #70811 in progress. Thanks @humblec

humblec added a commit to humblec/kubernetes that referenced this issue Nov 9, 2018

Update heketi dependencies to sha@558b29266ce0a873991ecfb3edc41a668a9…
…98514.

Fixes #
kubernetes#70802

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
@dims

This comment has been minimized.

Member

dims commented Nov 9, 2018

#70811 has merged.

/close

@dims dims closed this Nov 9, 2018

goodluckbot added a commit to goodluckbot/kubernetes that referenced this issue Nov 11, 2018

Update heketi dependencies to sha@558b29266ce0a873991ecfb3edc41a668a9…
…98514.

Fixes #
kubernetes#70802

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment