New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PullImage method in remote CRI receive PodSandboxConfig with a nil value #71745

Open
jorgesece opened this Issue Dec 5, 2018 · 3 comments

Comments

Projects
None yet
4 participants
@jorgesece

jorgesece commented Dec 5, 2018

What happened:
PullImage method in remote Container Runtime Interface (CRI) receives always PullImageRequest which contains the SandboxConfig object with a nil value.

type PullImageRequest struct {
   	// Spec of the image.
   	Image *ImageSpec `protobuf:"bytes,1,opt,name=image" json:"image,omitempty"`
   	// Authentication configuration for pulling the image.
   	Auth *AuthConfig `protobuf:"bytes,2,opt,name=auth" json:"auth,omitempty"`
   	// Config of the PodSandbox, which is used to pull image in PodSandbox context.
   	SandboxConfig *PodSandboxConfig `protobuf:"bytes,3,opt,name=sandbox_config,json=sandboxConfig" json:"sandbox_config,omitempty"`
   }

What you expected to happen:
SandboxConfig object must contain the sandbox configuration object.

How to reproduce it (as minimally and precisely as possible):
Create job by using kubectl create -f job.yaml

apiVersion: batch/v1
kind: Job
metadata:
  name: job-perl-docker
spec:
  template:
    metadata:
      labels:
        name: job-docker-template
    spec:
      containers:
      - name: job-docker-container
        image: perl
        command: ["sleep", "60"]
      restartPolicy: Never
      nodeSelector:
        beta.kubernetes.io/arch: amd64

Anything else we need to know?:

Environment:

  • Kubernetes version (use kubectl version): 1.12.0
  • Cloud provider or hardware configuration: minikube --vm-driver=none
  • OS (e.g. from /etc/os-release): ubuntu
  • Kernel (e.g. uname -a): Linux 4.13.0-16 x86_64
  • Install tools:
  • Others:

/kind bug

@jorgesece

This comment has been minimized.

jorgesece commented Dec 5, 2018

@kubernetes/sig-api-machinery-bug

@linxiulei

This comment has been minimized.

linxiulei commented Dec 6, 2018

I saw that as well, but I think it maybe a reserved field which has no actual use at PullImage. However, in my use case, I do have some uses for this field.

If needed I can contribute my patch for fixing it.

linxiulei added a commit to linxiulei/kubernetes that referenced this issue Dec 6, 2018

@linxiulei linxiulei referenced a pull request that will close this issue Dec 6, 2018

Open

Pass PodSandboxConfig to PullImage method in CRI #71764

@mysunshine92

This comment has been minimized.

Contributor

mysunshine92 commented Dec 6, 2018

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node and removed needs-sig labels Dec 6, 2018

linxiulei added a commit to linxiulei/kubernetes that referenced this issue Dec 6, 2018

linxiulei added a commit to linxiulei/kubernetes that referenced this issue Dec 6, 2018

linxiulei added a commit to linxiulei/kubernetes that referenced this issue Dec 6, 2018

linxiulei added a commit to linxiulei/kubernetes that referenced this issue Dec 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment