Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Sweep for calls to delete that result in orphaning dependents #71807
Several resources default to orphaning dependents for backwards compatibility:
Calls made via client-go to delete these resource via these versions which do not specify a deletion propagation policy default to orphaning dependents. For controller-deleted resources, this is almost always not what we want.
A specific example of this was #71772 that deleted jobs and accidentally orphaned pods.
We should sweep controller calls that delete the resources/versions listed above without specifying a deletion propagation policy and decide what policy is expected. In general, I would expect controllers to use background deletion propagation.