New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[scheduler] improve logging for successful binding #71819

Open
misterikkit opened this Issue Dec 6, 2018 · 4 comments

Comments

Projects
None yet
4 participants
@misterikkit
Contributor

misterikkit commented Dec 6, 2018

What would you like to be added:
We should add a log line (at V1 or V2) each time the scheduler successfully creates a binding. The log should include,

  • pod namespace/name
  • target node
  • number of nodes evaluated
  • number of feasible nodes found

Why is this needed:
If the scheduler thinks everything is going well, almost nothing gets logged about scheduling decisions. Adding this log will help us debug issues where, for example, the scheduler cache is out of sync with a node's state, and the node repeatedly rejects pods that we bind to it.

/sig scheduling

/kind feature

@misterikkit

This comment has been minimized.

Contributor

misterikkit commented Dec 6, 2018

/help
/good-first-issue

The right place to start is near the end of Scheduler.scheduleOne where we call metrics.PodScheduleSuccesses.Inc(), but some plumbing will be needed to get the node counts.

To anyone who wants to help with this, please make sure that sig-scheduling approves of this enhancement first.
/cc @bsalamat @k82cn

@wgliang

This comment has been minimized.

Member

wgliang commented Dec 7, 2018

I can take this if sig-scheduling approves of this enhancement.
/assign
/remove-help

@wgliang

This comment has been minimized.

Member

wgliang commented Dec 9, 2018

@k82cn @bsalamat
What‘s your opinions?I will submit PR if you think this is ok.

@bsalamat

This comment has been minimized.

Contributor

bsalamat commented Dec 10, 2018

@wgliang I agree that we need the log records.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment