New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[scheduler cleanup phase 2]: Rename pkg/scheduler/util
to pkg/scheduler/internal/podinfo
#71863
Comments
I will work on it |
/remove-help |
/assign @mysunshine92 |
@misterikkit: GitHub didn't allow me to assign the following users: mysunshine92. Note that only kubernetes members and repo collaborators can be assigned. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Hey @misterikkit @mysunshine92 , what's the status of this issue? Can l take this up as a beginning contribution to k8s? |
@misterikkit I am picking up this issue. I almost have a patch ready and will be opening a PR shortly. Do let me know if someone else is working on this. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle rotten |
I understand that no one is working on this now? |
I have the PR almost merged. |
@hprateek43 wasn't there more work pending than just that PR? /reopen |
@alculquicondor: Reopened this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@alculquicondor I am working on structuring the other PRs corresponding to this |
Thanks @hprateek43. Just remember to not put the word "Fixes" in your PR description unless it's the last PR. |
/reopen Please @hprateek43, remember to not use the word "Fixes" in your PRs if they are not the last one. |
@alculquicondor: Reopened this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @hprateek43, could you please do a survey of the remaining structs and functions in the util package and their usages? From there, we can decide what is the best location for each of them. |
@alculquicondor I will review the scheduler today and identify redundant components. Will open a cleanup PR |
@alculquicondor I reviewed the scheduler and think we can safely move |
@alculquicondor I am opening a new issue around channels that links to this one, the PR will fix that instead of this umbrella issue |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
@ahg-g do we still need this? |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Rotten issues close after 30d of inactivity. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
@fejta-bot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
PLEASE COORDINATE WITH SIG-SCHEDULING BEFORE WORKING ON THIS ISSUE. We want to avoid the situation where two people accidentally start work on the same fix.
Main tracking issue: #68951
If you contributed in phase 1, please give others a chance before claiming this issue. You can also help out by reviewing the phase 2 PRs.
This package contains only functions related to pods. Having “util” as a name is generally discouraged, since it doesn’t tell readers anything about what is in that package. This change will also mirror the change to create
pkg/scheduler/nodeinfo
which will have a bunch of node-related types and functions.GetPodPriority
from this package is used bypkg/kubelet/eviction
. In order to make our package internal, we should do one of the following. (1 is my preference)apimachinery
orclient-go
/sig scheduling
/kind cleanup
/help
/good-first-issue
The text was updated successfully, but these errors were encountered: