New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document/cleanup the kubernetes.io/cluster-service='true' label #72757

Open
alexbrand opened this Issue Jan 9, 2019 · 4 comments

Comments

Projects
None yet
5 participants
@alexbrand
Copy link
Member

alexbrand commented Jan 9, 2019

The kubernetes.io/cluster-service: "true" label is sprinkled across over 100 yaml files in the kubernetes repo (according to github search). However, I could not find any documentation around the effect of this label.

After searching the code base, it seems that:

  1. The label was being used by the addon manager in the past, but it has since been deprecated.
  2. The kubectl cluster-info command seems to be the only place where this label is used in the code. It is used to display the addresses of the services that contain this label.

Would it make sense to document this label, and also cleanup the instances of this label that exist on manifests that are not kind: Service?

/kind cleanup
/kind docs

@neolit123

This comment has been minimized.

Copy link
Member

neolit123 commented Jan 13, 2019

/remove-kind feature
/kind documentation
/sig cluster-lifecycle

The kubernetes.io/cluster-service: "true" label is sprinkled across over 100 yaml files in the kubernetes repo (according to github search). However, I could not find any documentation around the effect of this label.

previously the addons had documentation about the label:
https://github.com/kubernetes/kubernetes/blob/05ce0506f87f727fbadf0fc753a7af7c6675038a/cluster/addons/README.md

but it was removed as the label is deprecated..

Would it make sense to document this label, and also cleanup the instances of this label that exist on manifests that are not kind: Service?

since it's deprecated i don't think we should document it, but yes the YAMLs need a cleanup.

cc @MrHohn

@neolit123

This comment has been minimized.

Copy link
Member

neolit123 commented Jan 13, 2019

/remove-kind documentation
/kind cleanup

@MrHohn

This comment has been minimized.

Copy link
Member

MrHohn commented Jan 14, 2019

The kubectl cluster-info command seems to be the only place where this label is used in the code. It is used to display the addresses of the services that contain this label.

This is also what I found about this label. @kubernetes/sig-cli-maintainers is this label documented somewhere with kubectl?

@war-turtle

This comment has been minimized.

Copy link
Contributor

war-turtle commented Jan 16, 2019

@alexbrand @neolit123 @MrHohn
I think this issue should be labeled with help-wanted and good-first-issue.
I don't have rights.

@war-turtle war-turtle referenced a pull request that will close this issue Jan 16, 2019

Open

removing some cluster-service deprecated label #72973

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment