Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The max label value length is too low. #75380

Open
edgan opened this Issue Mar 14, 2019 · 1 comment

Comments

Projects
None yet
4 participants
@edgan
Copy link

edgan commented Mar 14, 2019

I want to have a AWS instance with a fqdn like the name below, but the current label value limit seems arbitrarily low. I should be able to set a FQDN as a label. As I feel like I should be able to set a subdomain as a label. I am aware of the design URL below. But I see no reason why labels should be limited to hostnames, and not allow things like subdomains or fqdns.

I would understand the restriction more if it was a limit on the title/name of the key, like kubernetes.io/hostname, but the limit on values doesn't make sense. If I took the hostname limit of 63, and the subdomain limit of 253, the total is 316, not 63.

A side effect is I am having to change the naming scheme to using a random custom eight character hash in place of the instance id to make sure the fqdn is unique.

Design URL:
https://github.com/kubernetes/community/blob/master/contributors/design-proposals/architecture/identifiers.md#identifiers-and-names-in-kubernetes

FQDN:
kube-frodo-worker-01a346cae00e2fcda.inf.us-west-2.aws.parsablenet.org <-- 69 characters

Instance id:
i-01a346cae00e2fcda

HOSTNAME:
kube-frodo-worker-01a346cae00e2fcda <--- 35 characters

SUBDOMAIN:
inf.us-west-2.aws.parsablenet.org <--- 33 characters

kubectl get nodes output:

NAME                                                           STATUS   ROLES    AGE     VERSION
kube-frodo-master-01.inf.us-west-2.aws.parsablenet.org         Ready    master   2d22h   v1.13.4-beta.0.57+ff2b76f1b5531b
kube-frodo-master-02.inf.us-west-2.aws.parsablenet.org         Ready    <none>   2d22h   v1.13.4-beta.0.57+ff2b76f1b5531b
kube-frodo-master-03.inf.us-west-2.aws.parsablenet.org         Ready    <none>   2d22h   v1.13.4-beta.0.57+ff2b76f1b5531b
kube-frodo-worker-01.inf.us-west-2.aws.parsablenet.org         Ready    <none>   2d22h   v1.13.4-beta.0.57+ff2b76f1b5531b
kube-frodo-worker-02.inf.us-west-2.aws.parsablenet.org         Ready    <none>   2d22h   v1.13.4-beta.0.57+ff2b76f1b5531b
kube-frodo-worker-03.inf.us-west-2.aws.parsablenet.org         Ready    <none>   2d22h   v1.13.4-beta.0.57+ff2b76f1b5531b
kube-frodo-worker-bec22759.inf.us-west-2.aws.parsablenet.org   Ready    <none>   18h     v1.13.4-beta.0.57+ff2b76f1b5531b
kube-frodo-worker-f6cac2eb.inf.us-west-2.aws.parsablenet.org   Ready    <none>   18h     v1.13.4-beta.0.57+ff2b76f1b5531b

Sample from kubectl get node kube-frodo-master-01.inf.us-west-2.aws.parsablenet.org -o yaml:

    kubernetes.io/hostname: kube-frodo-master-01.inf.us-west-2.aws.parsablenet.org
  name: kube-frodo-master-01.inf.us-west-2.aws.parsablenet.org

@edgan edgan added the kind/bug label Mar 14, 2019

@neolit123

This comment has been minimized.

Copy link
Member

neolit123 commented Mar 15, 2019

/sig aws

@k8s-ci-robot k8s-ci-robot added sig/aws and removed needs-sig labels Mar 15, 2019

@liggitt liggitt added kind/feature and removed kind/bug labels Mar 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.