Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove kube-proxy's automatic clean up logic #75408

Closed
andrewsykim opened this Issue Mar 15, 2019 · 7 comments

Comments

Projects
4 participants
@andrewsykim
Copy link
Member

commented Mar 15, 2019

What would you like to be added:
Remove any logic in kube-proxy that tries to automatically clean up proxy rules based on the proxy mode. Only attempt to clean up if --cleanup is set.

Why is this needed:
This is a continuation of a discussion from #75377. There's a lot of complexity that comes with switching the proxy mode on kube-proxy because it tries to delete proxy rules created from other proxy modes. This has a lot of side-effects and we should be encouraging users to reboot thier nodes along with switching proxy modes. One example of this can be found #75360.

@andrewsykim

This comment has been minimized.

Copy link
Member Author

commented Mar 15, 2019

/sig network

@vllry

This comment has been minimized.

Copy link
Contributor

commented Mar 15, 2019

I can take this on - does this issue have/need a KEP?

@andrewsykim

This comment has been minimized.

Copy link
Member Author

commented Mar 15, 2019

I think not but will defer to @thockin @bowei

@bowei bowei added this to Triage in SIG-NETWORK Mar 15, 2019

@thockin

This comment has been minimized.

Copy link
Member

commented Mar 15, 2019

I think a micro-KEP is appropriate.

Specifically to talk about compatibility with regards to flags and to talk about docs (not sure which, but we have to write this down :)

@thockin

This comment has been minimized.

Copy link
Member

commented Mar 15, 2019

also to talk about --cleanup (I think it should probably clean up its own mode, not the others -- or maybe I am wrong, please think about the right thing here :)

@vllry

This comment has been minimized.

Copy link
Contributor

commented Mar 18, 2019

/assign @vllry

(Yay, I can do this now!)

@vllry

This comment has been minimized.

Copy link
Contributor

commented Mar 22, 2019

/priority important-soon

vllry added a commit to vllry/enhancements that referenced this issue Mar 25, 2019

@bowei bowei moved this from Triage to To do in SIG-NETWORK Mar 25, 2019

@bowei bowei moved this from To do to KEP in SIG-NETWORK Mar 25, 2019

SIG-NETWORK automation moved this from KEP to Done Apr 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.