Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have `NewWatcher` of plugin watcher return an interface instead of a struct #76539

taragu opened this Issue Apr 13, 2019 · 1 comment


None yet
3 participants
Copy link

taragu commented Apr 13, 2019

What would you like to be added:
After PR #73891 is merged, refactor pkg/kubelet/pluginmanager/pluginwatcher/plugin_watcher.go so that NewWatcher(...) should return a Watcher interface instead of a struct.

Why is this needed:
This will make testing easier as fake implementation can be used easily.

FYI @saad-ali
/assign @taragu


This comment has been minimized.

Copy link

neolit123 commented Apr 13, 2019

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node and removed needs-sig labels Apr 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.