Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store parsed CIDRs at initialization of Proxier #76544

Open
tedyu opened this Issue Apr 13, 2019 · 4 comments

Comments

Projects
None yet
5 participants
@tedyu
Copy link
Contributor

tedyu commented Apr 13, 2019

What would you like to be added:
Change excludeCIDRs from []string to []*IPNet in Proxier and perform the parsing at construction of Proxier.

Why is this needed:
This was proposed by @lbernail over comments in Pr #76334

This improves the performance of isIPInExcludeCIDRs since the cost of parsing becomes one time.

@vllry

This comment has been minimized.

Copy link
Contributor

vllry commented Apr 13, 2019

/sig network
/kind cleanup

@vllry

This comment has been minimized.

Copy link
Contributor

vllry commented Apr 13, 2019

/remove-kind feature

@athenabot

This comment has been minimized.

Copy link

athenabot commented Apr 13, 2019

/triage unresolved

🤖 I am a bot run by @vllry. 👩‍🔬

@tedyu

This comment has been minimized.

Copy link
Contributor Author

tedyu commented Apr 15, 2019

ping @lbernail

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.