Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support label selector in MutatingWebhook #76697

Closed
ChenLingPeng opened this issue Apr 17, 2019 · 3 comments
Closed

support label selector in MutatingWebhook #76697

ChenLingPeng opened this issue Apr 17, 2019 · 3 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.

Comments

@ChenLingPeng
Copy link
Contributor

What would you like to be added:
In webbook, I would like to add a labelSelector to filter which object should be called with webhook, just like namespaceSelector

Why is this needed:

In istio, we use MutatingWebhook to inject sidecar into pod. For now, webhook only supports namespaceSelector, so when the namespace match, all pods in the namespace will call webhook to check if inject is necessary. In the real world, not all pods in the namespace needs inject. And in some bad case, when the webhook service goes down, it will affect the pods which have no need to inject. So I suggest adding a labelSelector.

@ChenLingPeng ChenLingPeng added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 17, 2019
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Apr 17, 2019
@ChenLingPeng
Copy link
Contributor Author

/sig api-machinery

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 17, 2019
@liggitt
Copy link
Member

liggitt commented Apr 17, 2019

@k8s-ci-robot
Copy link
Contributor

@liggitt: Closing this issue.

In response to this:

this is planned in https://github.com/kubernetes/enhancements/blob/master/keps/sig-api-machinery/00xx-admission-webhooks-to-ga.md#object-selector and tracked in kubernetes/enhancements#492

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.
Projects
None yet
Development

No branches or pull requests

3 participants