Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling E2E tests using to be deprecated features like 'NodeSelector' #78891

Open
globervinodhn opened this issue Jun 11, 2019 · 2 comments

Comments

3 participants
@globervinodhn
Copy link
Contributor

commented Jun 11, 2019

What would you like to be added:
As per the link, https://kubernetes.io/docs/concepts/configuration/assign-pod-node/#affinity-and-anti-affinity - NodeSelector is to be deprecated.
Extract:- "nodeSelector continues to work as usual, but will eventually be deprecated, as node affinity can express everything that nodeSelector can express."

Under this scenario, I have the following queries:-

  1. Should we avoid using NodeSelector feature for new E2E tests?
  2. How to handle the current E2E tests which aren't conformance promoted?
    a. Can they be promoted as it is, provided they meet the conformance needs? or
    b. Should the tests be altered to use NodeAffinity and then promoted?

Why is this needed:
To have a confirmed way to handle 'to be deprecated' features.

@globervinodhn

This comment has been minimized.

Copy link
Contributor Author

commented Jun 11, 2019

/area conformance
/sig architecture
/sig testing
/sig scheduling
/kind cleanup

@mgdevstack

This comment has been minimized.

Copy link
Member

commented Jun 11, 2019

IMO,

Should we avoid using NodeAffinity NodeSelector feature for new E2E tests?

+1 for all new e2e to use NodeAffinity instead of NodeSelector as NodeAffinity can handle broader range constraints.

Can they be promoted as it is, provided they meet the conformance needs?

+1, for upcoming release i.e. v1.6, this is definitely a candidate for promotion. There is no such clarity about the release since when NodeSelector would be deprecated. Once it is deprecated, respective Conformance e2e can be demoted following Conformance Test Version Skew Policy

Should the tests be altered to use NodeAffinity and then promoted?

-1, As it is not yet deprecated and aligned with version-skew-policy, it shouldn't be altered. Instead writing new e2e to support NodeAffinity would be good expressing various nodeSelectorTerms.

@timothysc timothysc added this to To Triage in cncf-k8s-conformance-wg via automation Jun 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.