Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade tests do not check pod instances and restart counts are identical for workload objects #78904

Open
liggitt opened this issue Jun 11, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@liggitt
Copy link
Member

commented Jun 11, 2019

What happened:

An upgrade of only the API server should not result in pod recreations or container restarts.

Today, this can accidentally be triggered by introducing new defaults to types within PodSpec (c.f. #69988, #69445, #78633).

The workload upgrade tests do not currently check if pod instances and container restart counts are identical.

What you expected to happen:

At the end of the upgrade test setup step, record the pod instances for the workload object in question, their uids, container restart counts, and associated node names and versions.

In the verification step post-upgrade, if the associated nodes still exist at the same versions, verify the same pod instances still exist with the same container restart counts.

For bonus points, an unrelated update (e.g. adding an annotation to the workload object) should be performed, to verify that no defaults are added in the update path that would result in a spurious rollout of new pods.

/sig testing
/sig apps
/priority important-soon

@liggitt

This comment has been minimized.

Copy link
Member Author

commented Jun 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.