Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update libopenstorage/openstorage dependency to a release version #80029

Open
dims opened this issue Jul 11, 2019 · 6 comments

Comments

Projects
None yet
3 participants
@dims
Copy link
Member

commented Jul 11, 2019

Found this when trying to see which vendored dependencies does not use a proper tag (and is using a random SHA).

The https://github.com/libopenstorage/openstorage dependency is very old and there have been a lot of updates to it:
Looks like the libopenstorage/openstorage@093a0c3...v8.0.0

However there does not seem to be anyone around to take care of the portworx plugin. Is it time to deprecate it? is anyone using it?

/sig storage

@dims

This comment has been minimized.

Copy link
Member Author

commented Jul 11, 2019

@dims

This comment has been minimized.

Copy link
Member Author

commented Jul 11, 2019

/area code-organization

@harsh-px

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2019

Hello @pditommaso, The portworx volume plugin is definitely in use.

The portworx volume plugin doesn't need frequent updates since the plugin acts as a simple client to all provisioning calls. In the same view, the vendored openstorage package doesn't need to be updated too. The server side implementation in Portworx handles all the latest Portworx features.

@harsh-px

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2019

cc: @lpabon

@dims

This comment has been minimized.

Copy link
Member Author

commented Jul 11, 2019

@harsh-px in that case, can you please update the dependency to a specific tag instead of a random SHA?

@dims dims changed the title Deprecate portworx volume plugin Update libopenstorage/openstorage dependency to a release version Jul 12, 2019

@dims

This comment has been minimized.

Copy link
Member Author

commented Jul 12, 2019

/assign @harsh-px

updated the title of the issue as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.