Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncertain volumes are not detached from node #81365

Open
gnufied opened this issue Aug 13, 2019 · 3 comments

Comments

@gnufied
Copy link
Member

commented Aug 13, 2019

it looks like the cleanup of uncertain volumes introduced in #71276 is problematic.

The problem is - when a volume is added as "uncertain" to the actual state of the world, it does not actually get added to nodesToUpdateStatusFor map so removeVolumeFromReportAsAttached fails with:

	return fmt.Errorf("volume %q does not exist in volumesToReportAsAttached list or node %q does not exist in nodesToUpdateStatusFor list",
		volumeName,
		nodeName)

I propose that - we fix this by not returning error in removeVolumeFromReportAsAttached if volume was marked uncertain.

/sig storage

cc @jingxu97

@gnufied

This comment has been minimized.

Copy link
Member Author

commented Aug 13, 2019

@gnufied

This comment has been minimized.

Copy link
Member Author

commented Aug 13, 2019

I think another issue is - when a uncertain volume is detached and detach fails, it will cause uncertain volume to be reported to node's status which is not something we want.

@gnufied

This comment has been minimized.

Copy link
Member Author

commented Aug 15, 2019

Hmm.. so looks like my original issue was not entirely valid, we seem to be calling detach even if volume fails to remove from nodesToUpdateStatusFor field, but we are adding the volume back to nodesToUpdateStatusFor field if detach fails, but this is less of a fatal error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.