Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

//test/instrumentation:list_stable_metrics fails due to argument list #81400

Open
cblecker opened this issue Aug 14, 2019 · 3 comments

Comments

@cblecker
Copy link
Member

commented Aug 14, 2019

bazel-out/darwin-fastbuild/bin/test/instrumentation/list_stable_metrics.genrule_script.sh: line 2: ./bazel-out/host/bin/test/instrumentation/darwin_amd64_stripped/instrumentation: Argument list too long

/assign @serathius
/cc @logicalhan @brancz
/sig instrumentation

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 14, 2019

@cblecker: GitHub didn't allow me to assign the following users: serathius.

Note that only kubernetes members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

bazel-out/darwin-fastbuild/bin/test/instrumentation/list_stable_metrics.genrule_script.sh: line 2: ./bazel-out/host/bin/test/instrumentation/darwin_amd64_stripped/instrumentation: Argument list too long

/assign @serathius
/cc @logicalhan @brancz
/sig instrumentation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@serathius

This comment has been minimized.

Copy link
Contributor

commented Aug 14, 2019

Hey @cblecker,
Looks like this test is passing on testgrid, https://k8s-testgrid.appspot.com/presubmits-kubernetes-blocking#pull-kubernetes-bazel-test&include-filter-by-regex=instrumentation%3Averify_stable_metric
Which would point to problem being related to specific environment.

From your log looks like problem is specific to Macs. I will try to reproduce it to confirm it.

My current ideas for solution are:

  • Disabling test on Mac
  • Instead of passing files as arguments, pass them in STDIN

WDYT?

@BenTheElder

This comment has been minimized.

Copy link
Member

commented Aug 17, 2019

FWIW ARG_MAX can technically vary even on linux ...?
STDIN SGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.