New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move hyperkube binary and images out from main k/k repository #81760
Comments
We will need the generated openapi check in if we want k/k to be vendorable, see #81239 |
/sig architecture |
@dims Yeah, Hyperkube is of interest to our Windows testing effort, as we depend on it to deploy our test clusters with aks-engine. I can help with moving it and making the transition smooth. |
I filed Azure/aks-engine#1842 to track removing this dependency in AKS-Engine |
@dims any updates on this? |
I started some work on pulling it from the main k/k repo, I'm still slowly working on build scripts. Will update when I have a PR in a week or two ( depending on the volume of my other commitments ). |
thanks @adelina-t |
As mentioned earlier, i have https://github.com/dims/hyperkube and looks like @adelina-t will be surfacing another repository as well. We can pick either one ( preferably @adelina-t 's) and request a new repository under We will need folks who want to own this code and take it forward. So if you are interested, please chime in on this issue. cc @dghubble @PatrickLang @MikeSpreitzer @neolit123 @vllry @deads2k @justaugustus |
@dims -- SIG Release is on the hook to own and I'll steward. From the contributors you mentioned, I'll find some key approvers. |
i think we should create the k/k-sig hosted hyperkube repo and start moving bits to there. |
You can have a look here at the initial move: https://github.com/adelina-t/hyperkube Hyperkube can be built, images can be built here. |
@justaugustus @adelina-t thanks! https://github.com/adelina-t/hyperkube is a great way to get us started. |
@dims Kubernetes core still plans to package other container images like kube-apiserver, kube-scheduler, kube-controller-manager? The desire is specific to moving the hyperkube image management, not container images distributables right? |
@dghubble correct |
The script ./dev-push-hyperkube.sh was removed from Kubernetes recently in a general effort of moving Hyperkube away from the k/k repo (see kubernetes/kubernetes#81760). Until hyperkube gets an official home and it is completely removed from k/k, we will need to build it manually from within the k8s repo. This affects the upstream Windows 1.17 jobs ( https://testgrid.k8s.io/sig-windows#aks-engine-azure-windows-master-staging and https://testgrid.k8s.io/sig-windows#aks-engine-azure-windows-master)
The script ./dev-push-hyperkube.sh was removed from Kubernetes recently in a general effort of moving Hyperkube away from the k/k repo (see kubernetes/kubernetes#81760). Until hyperkube gets an official home and it is completely removed from k/k, we will need to build it manually from within the k8s repo. This affects the upstream Windows 1.17 jobs ( https://testgrid.k8s.io/sig-windows#aks-engine-azure-windows-master-staging and https://testgrid.k8s.io/sig-windows#aks-engine-azure-windows-master)
/assign |
@uablrek when we have a new github repository where you can do the same thing. @justaugustus do we want to do that this week? |
@dims -- Yep, it's top of mind to get the ball rolling on the migration this week! |
/cc |
Migration issue opened in k/org: kubernetes/org#1365 |
If we want to provide the same functionality as hyperkube via another project, I think it would make more sense to do so with a shim executable that delegates to actual binaries, and to build an image that actually contained the official binaries. That could be done with a single go file, a Dockerfile, and a build script, with no go dependency on k8s.io/kubernetes. |
That lets the hyperkube image just be a packaging mechanism, and the hyperkube binary avoid dependency entanglement. |
In the immediate term, I noticed v1.17 beta images for hyperkube were never published. I was hoping to do my usual testing now that beta's are out, especially if its moving. Seems like its no longer in the release flow, but also doesn't have the new home? |
/close TL;DR we are not moving the binary/image from k/k, we have an alternative container image based on a script now. |
@dims: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
At one point hyperkube was going to take everything over but that day is gone:
#16508
We don't have any owners for hyperkube and we have pending issues like #80374 and #71719
hyperkube is a magnet for pulling all kinds of dependencies (especially cloud providers)
We asked this question once earlier in:
#69896
And it's easy to pull it out of k/k repository - POC is here : https://github.com/dims/hyperkube
floated the idea on mailing lists:
found some folks who may want / be able to help: @feiskyer @adelina-t @PatrickLang @markyjackson-taulia
/area code-organization
The text was updated successfully, but these errors were encountered: