Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move hyperkube binary and images out from main k/k repository #81760

Closed
dims opened this issue Aug 22, 2019 · 29 comments
Closed

Move hyperkube binary and images out from main k/k repository #81760

dims opened this issue Aug 22, 2019 · 29 comments
Assignees
Labels
area/code-organization area/release-eng kind/feature priority/important-soon sig/architecture
Milestone

Comments

@dims
Copy link
Member

@dims dims commented Aug 22, 2019

At one point hyperkube was going to take everything over but that day is gone:
#16508

We don't have any owners for hyperkube and we have pending issues like #80374 and #71719

hyperkube is a magnet for pulling all kinds of dependencies (especially cloud providers)

We asked this question once earlier in:
#69896

And it's easy to pull it out of k/k repository - POC is here : https://github.com/dims/hyperkube

floated the idea on mailing lists:

found some folks who may want / be able to help: @feiskyer @adelina-t @PatrickLang @markyjackson-taulia

/area code-organization

@dims dims added the kind/feature label Aug 22, 2019
@k8s-ci-robot k8s-ci-robot added area/code-organization needs-sig labels Aug 22, 2019
@dims
Copy link
Member Author

@dims dims commented Aug 22, 2019

We will need the generated openapi check in if we want k/k to be vendorable, see #81239

@neolit123
Copy link
Member

@neolit123 neolit123 commented Aug 29, 2019

/sig architecture

@k8s-ci-robot k8s-ci-robot added sig/architecture and removed needs-sig labels Aug 29, 2019
@adelina-t
Copy link
Contributor

@adelina-t adelina-t commented Aug 30, 2019

@dims Yeah, Hyperkube is of interest to our Windows testing effort, as we depend on it to deploy our test clusters with aks-engine. I can help with moving it and making the transition smooth.

@PatrickLang
Copy link
Contributor

@PatrickLang PatrickLang commented Sep 3, 2019

cc @ritazh @jackfrancis

I filed Azure/aks-engine#1842 to track removing this dependency in AKS-Engine

@feiskyer
Copy link
Member

@feiskyer feiskyer commented Sep 10, 2019

@dims any updates on this?

@adelina-t
Copy link
Contributor

@adelina-t adelina-t commented Sep 17, 2019

I started some work on pulling it from the main k/k repo, I'm still slowly working on build scripts. Will update when I have a PR in a week or two ( depending on the volume of my other commitments ).

@dims
Copy link
Member Author

@dims dims commented Sep 17, 2019

thanks @adelina-t

@dims
Copy link
Member Author

@dims dims commented Oct 4, 2019

As mentioned earlier, i have https://github.com/dims/hyperkube and looks like @adelina-t will be surfacing another repository as well. We can pick either one ( preferably @adelina-t 's) and request a new repository under kubernetes-sigs.

We will need folks who want to own this code and take it forward. So if you are interested, please chime in on this issue.

cc @dghubble @PatrickLang @MikeSpreitzer @neolit123 @vllry @deads2k @justaugustus

@justaugustus
Copy link
Member

@justaugustus justaugustus commented Oct 4, 2019

@dims -- SIG Release is on the hook to own and I'll steward.

From the contributors you mentioned, I'll find some key approvers.

@neolit123
Copy link
Member

@neolit123 neolit123 commented Oct 4, 2019

i think we should create the k/k-sig hosted hyperkube repo and start moving bits to there.

@adelina-t
Copy link
Contributor

@adelina-t adelina-t commented Oct 4, 2019

You can have a look here at the initial move: https://github.com/adelina-t/hyperkube

Hyperkube can be built, images can be built here.
Next steps: create dependancy pinning / vendor update scripts.

@dims
Copy link
Member Author

@dims dims commented Oct 4, 2019

@justaugustus @adelina-t thanks! https://github.com/adelina-t/hyperkube is a great way to get us started.

@dghubble
Copy link
Contributor

@dghubble dghubble commented Oct 4, 2019

@dims Kubernetes core still plans to package other container images like kube-apiserver, kube-scheduler, kube-controller-manager? The desire is specific to moving the hyperkube image management, not container images distributables right?

@dims
Copy link
Member Author

@dims dims commented Oct 4, 2019

@dghubble correct

adelina-t added a commit to adelina-t/test-infra that referenced this issue Oct 7, 2019
The script ./dev-push-hyperkube.sh was removed from Kubernetes
recently in a general effort of moving Hyperkube away from the
k/k repo (see kubernetes/kubernetes#81760).

Until hyperkube gets an official home and it is completely removed
from k/k, we will need to build it manually from within the k8s
repo.

This affects the upstream Windows 1.17 jobs (
https://testgrid.k8s.io/sig-windows#aks-engine-azure-windows-master-staging
and
https://testgrid.k8s.io/sig-windows#aks-engine-azure-windows-master)
adelina-t added a commit to adelina-t/test-infra that referenced this issue Oct 7, 2019
The script ./dev-push-hyperkube.sh was removed from Kubernetes
recently in a general effort of moving Hyperkube away from the
k/k repo (see kubernetes/kubernetes#81760).

Until hyperkube gets an official home and it is completely removed
from k/k, we will need to build it manually from within the k8s
repo.

This affects the upstream Windows 1.17 jobs (
https://testgrid.k8s.io/sig-windows#aks-engine-azure-windows-master-staging
and
https://testgrid.k8s.io/sig-windows#aks-engine-azure-windows-master)
@justaugustus
Copy link
Member

@justaugustus justaugustus commented Oct 7, 2019

/assign

@justaugustus justaugustus added this to Backlog in Release Engineering via automation Oct 15, 2019
@justaugustus justaugustus moved this from Backlog to In progress in Release Engineering Oct 15, 2019
@justaugustus justaugustus added this to the v1.17 milestone Oct 15, 2019
@dims
Copy link
Member Author

@dims dims commented Oct 28, 2019

@uablrek when we have a new github repository where you can do the same thing.

@justaugustus do we want to do that this week?

@justaugustus justaugustus moved this from Backlog to In progress in code-organization subproject Oct 28, 2019
@justaugustus
Copy link
Member

@justaugustus justaugustus commented Oct 28, 2019

@dims -- Yep, it's top of mind to get the ball rolling on the migration this week!

@ereslibre
Copy link
Member

@ereslibre ereslibre commented Oct 28, 2019

/cc

@justaugustus
Copy link
Member

@justaugustus justaugustus commented Oct 31, 2019

Migration issue opened in k/org: kubernetes/org#1365

@liggitt
Copy link
Member

@liggitt liggitt commented Oct 31, 2019

If we want to provide the same functionality as hyperkube via another project, I think it would make more sense to do so with a shim executable that delegates to actual binaries, and to build an image that actually contained the official binaries. That could be done with a single go file, a Dockerfile, and a build script, with no go dependency on k8s.io/kubernetes.

@liggitt
Copy link
Member

@liggitt liggitt commented Oct 31, 2019

That lets the hyperkube image just be a packaging mechanism, and the hyperkube binary avoid dependency entanglement.

@dghubble
Copy link
Contributor

@dghubble dghubble commented Oct 31, 2019

In the immediate term, I noticed v1.17 beta images for hyperkube were never published. I was hoping to do my usual testing now that beta's are out, especially if its moving. Seems like its no longer in the release flow, but also doesn't have the new home?

@dims
Copy link
Member Author

@dims dims commented Nov 3, 2019

@dghubble we are re-working the hyperkube image like @liggitt mentioned, please follow along in #84662

@dims
Copy link
Member Author

@dims dims commented Nov 7, 2019

/close

TL;DR we are not moving the binary/image from k/k, we have an alternative container image based on a script now.

@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Nov 7, 2019

@dims: Closing this issue.

In response to this:

/close

TL;DR we are not moving the binary/image from k/k, we have an alternative container image based on a script now.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/code-organization area/release-eng kind/feature priority/important-soon sig/architecture
Development

No branches or pull requests