Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove direct references to prometheus methods #82510

Open
logicalhan opened this issue Sep 9, 2019 · 1 comment

Comments

@logicalhan
Copy link
Contributor

commented Sep 9, 2019

To get metrics stability into Beta, we will make it illegal to directly import prometheus methods in Kubernetes components. This will insure that all new metrics are instantiated using the correct wrapper methods. To do this, we need to provide wrappers for the direct prometheus method calls (namely, prometheus.Bucket methods and prometheus.Collector/Desc methods).

/sig instrumentation

@irajdeep

This comment has been minimized.

Copy link
Contributor

commented Sep 12, 2019

@logicalhan I can work on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.