Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PodReadinessGate to support conditions defaulting to True #83628

Open
nimakaviani opened this issue Oct 8, 2019 · 1 comment

Comments

@nimakaviani
Copy link

commented Oct 8, 2019

Currently PodReadinessGate requires a two-step update to the Pod for a user provided condition to be set to True.

  1. The conditionType is introduced when creating the pod
  2. The Pod status is patched to set the condition to True.

While the behavior works for the initially intended purpose of this field (ie. more control over when to make the Pod available for routing traffic), reversing this behavior is not easily achieved.

We would like to use the user provided readiness conditions as a way to notify the control plane that a given pod needs to stop serving traffic and its respective endpoints need to be removed.

As such, ideally we would like to create the pod with the custom pod condition set to True by default to be able to toggle it to False and retrigger reconciliation at a later point as needed.

PodReadinessGate supporting custom conditions defaulting to True, appears to be the right approach to it.

/cc @greghaynes
/sig apps
/sig api-machinery

@roycaihw

This comment has been minimized.

Copy link
Member

commented Oct 10, 2019

/remove-sig api-machinery

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.