Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSI cleans up MetaData file when MountDevice times out #83691

Open
rvakash opened this issue Oct 9, 2019 · 2 comments

Comments

@rvakash
Copy link

commented Oct 9, 2019

What happened:
MountDevice calls csi.NodeStageVolume and if the call times out the defer func() cleans up the MetaData file. If the call to stage eventually goes through and the mount succeeds, future call to MountDevice will bail out since the directory is already mounted and it will return success without creating the meta files and thus causing the future UnmountDevice to fail even before making csi.NodeUnstageVolume call.

What you expected to happen:
UnmountDevice to go through.

How to reproduce it (as minimally and precisely as possible):
Make the csi plugin NodeStageVolume implementation to take more than csiTimeout specified

Environment:

  • Kubernetes version (use kubectl version): master
@rvakash rvakash added the kind/bug label Oct 9, 2019
@rvakash

This comment has been minimized.

Copy link
Author

commented Oct 9, 2019

/sig storage
/assign @jsafrane @saad-ali @vladimirvivien

@msau42

This comment has been minimized.

Copy link
Member

commented Oct 9, 2019

This is probably the same issue as #82190
/assign @gnufied

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.