Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving CSI Driver to GA. #84814

Merged
merged 4 commits into from Mar 6, 2020
Merged

Moving CSI Driver to GA. #84814

merged 4 commits into from Mar 6, 2020

Conversation

huffmanca
Copy link
Contributor

@huffmanca huffmanca commented Nov 5, 2019 •
edited

What type of PR is this?
/kind feature

What this PR does / why we need it:
Graduates the CSI Driver to GA. This only touches the API, their tests, and the associated staging files.

Which issue(s) this PR fixes:
Fixes kubernetes/enhancements#770

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

The storage.k8s.io/CSIDriver has moved to GA, and is now available for use.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/pull/768

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 5, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @huffmanca. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added area/kubelet kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 5, 2019
@huffmanca huffmanca changed the title Moving CSI Driver and Node to GA. [wip] Moving CSI Driver and Node to GA. Nov 5, 2019
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 5, 2019
@huffmanca huffmanca changed the title [wip] Moving CSI Driver and Node to GA. [wip] Moving CSI Driver to GA. Nov 5, 2019
@huffmanca huffmanca changed the title [wip] Moving CSI Driver to GA. Moving CSI Driver to GA. Nov 5, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 5, 2019
@fejta-bot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@gnufied
Copy link
Member

gnufied commented Nov 5, 2019

/ok-to-test
/sig storage
/priority important-soon

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 5, 2019
@huffmanca
Copy link
Contributor Author

/test pull-kubernetes-e2e-kind

@huffmanca
Copy link
Contributor Author

@smarterclayton ,

After discussing this with @gnufied further, I've removed listType from the Items[] field and added a single API violation for this type.

@smarterclayton
Copy link
Contributor

smarterclayton commented Mar 5, 2020 •
edited

/approve

API change is approved.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: huffmanca, jsafrane, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2020
@huffmanca
Copy link
Contributor Author

/test pull-kubernetes-e2e-kind

@msau42
Copy link
Member

msau42 commented Mar 6, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 6, 2020
@huffmanca
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce

@irvifa
Copy link
Member

irvifa commented Mar 6, 2020

@huffmanca I think you need to rebase this PR first.. There's a conflict on the csi_mounter

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 6, 2020
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 6, 2020
@huffmanca
Copy link
Contributor Author

/test pull-kubernetes-conformance-kind-ipv6-parallel

@jsafrane
Copy link
Member

jsafrane commented Mar 6, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 6, 2020
@k8s-ci-robot k8s-ci-robot merged commit 61847ea into kubernetes:master Mar 6, 2020
This was referenced Mar 6, 2020
Merged
Merged
@huffmanca huffmanca mentioned this pull request Apr 17, 2020
Closed
6 tasks
@ialidzhikov ialidzhikov mentioned this pull request Apr 21, 2020
Merged
@tjkirch tjkirch mentioned this pull request Oct 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnufied gnufied gnufied left review comments

@smarterclayton smarterclayton smarterclayton requested changes

@bertinatto bertinatto bertinatto left review comments

@jsafrane jsafrane jsafrane left review comments

@msau42 msau42 msau42 left review comments

@cheftako cheftako Awaiting requested review from cheftako

@dashpole dashpole Awaiting requested review from dashpole

Assignees

@smarterclayton smarterclayton

@jsafrane jsafrane

@msau42 msau42

Labels
api-review Categorizes an issue or PR as actively needing an API review. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

Skip attach for non-attachable CSI volumes