Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate Retry-After: hint for control plane 429 responses #84903

Open
sftim opened this issue Nov 7, 2019 · 3 comments

Comments

@sftim
Copy link
Contributor

@sftim sftim commented Nov 7, 2019

Related to #76846

What would you like to be added:
When the control plane responds with a 429 status, and the client was authenticated, add a Retry-After: header to the response with a relevant hint about when to retry.

Why is this needed:
HTTP responses with 429 status code MAY include a Retry-After header indicating how long to wait before making a new request.

Adding a hint to clients about when to retry lets them avoid sending a request to the control plane before the control plane would be willing to accept it.

The GA implementation in maxinflight.go sends this header but with a fixed value of 1, which does not give clients a good hint about when to retry.

@sftim

This comment has been minimized.

Copy link
Contributor Author

@sftim sftim commented Nov 7, 2019

/sig api-machinery

@jennybuckley

This comment has been minimized.

Copy link
Contributor

@jennybuckley jennybuckley commented Nov 7, 2019

@jennybuckley

This comment has been minimized.

Copy link
Contributor

@jennybuckley jennybuckley commented Nov 7, 2019

/assign @yliaog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.