Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

json unmarshal coded error at function applyJSPatch() #84908

Closed
attlee-wang opened this issue Nov 7, 2019 · 3 comments · Fixed by #84963
Assignees

Comments

@attlee-wang
Copy link
Contributor

@attlee-wang attlee-wang commented Nov 7, 2019

What happened:
It returns an error when I create a pod of yaml file over 1M. I checked the codes and found that the coded wrong. It should be “json.Unmarshal(p.patchBytes, &v)”, not “json.Unmarshal(p.patchBytes, v)” in the staging/src/k8s.io/apiserver/pkg/endpoints/handlers/patch.go 344 and 368 line.

What you expected to happen:
It can be parsed correctly.

How to reproduce it (as minimally and precisely as possible):
Look at the code and you'll see or you can test it.

Anything else we need to know?:
no.
Environment:

  • Kubernetes version (use kubectl version): Community latest code
  • Cloud provider or hardware configuration:
  • OS (e.g: cat /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Network plugin and version (if this is a network-related bug):
  • Others:
@honkiko

This comment has been minimized.

Copy link
Contributor

@honkiko honkiko commented Nov 7, 2019

/kind bug

@honkiko

This comment has been minimized.

Copy link
Contributor

@honkiko honkiko commented Nov 7, 2019

/sig api-machinery

@jennybuckley

This comment has been minimized.

Copy link
Contributor

@jennybuckley jennybuckley commented Nov 7, 2019

/assign @liggitt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.