Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defaulting seems to be broken for autoscaling/v2beta2 api group #84990

Open
wojtek-t opened this issue Nov 8, 2019 · 0 comments

Comments

@wojtek-t
Copy link
Member

@wojtek-t wojtek-t commented Nov 8, 2019

This function is defined and not used anywhere:
https://github.com/kubernetes/kubernetes/blob/master/pkg/apis/autoscaling/v2beta2/defaults.go#L30

The reason seem to be the missing tag here:
https://github.com/kubernetes/kubernetes/blob/master/pkg/apis/autoscaling/v2beta2/doc.go#L18

// +k8s:defaulter-gen-input=../../../../vendor/k8s.io/api/autoscaling/v2beta2

That said - it seems to be causing some test failures.

Please take a look and fix.

@kubernetes/sig-autoscaling-bugs
@josephburnett

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.