Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate Transitive Deps from docker/libnetwork #85005

Open
andrewsykim opened this issue Nov 8, 2019 · 4 comments

Comments

@andrewsykim
Copy link
Member

@andrewsykim andrewsykim commented Nov 8, 2019

What would you like to be added:
github.com/docker/libnetwork has a lot of transitive deps but we only use its (relatively small) ipvs package for kube-proxy. Luckily because it doesn't use go modules yet, updating it doesn't actually update it's transitive deps, but if/when it does, managing it's transitive deps will be a pain because of its overlapping transitive deps to our other dependencies.

From doing a quick search of the Kubernetes repo, we only use the ipvs package from github.com/docker/libnetwork. Some options going forward would be:

  • fork that repo with only the ipvs package
  • copy the ipvs package to k8s.io/kubernetes
  • ask the docker maintainers to put the ipvs package into a separate repo
  • ???

Open to other options I haven't considered yet.

Why is this needed:
Will significantly improve the maintainability of our dependencies once github.com/docker/libnetwork uses go modules.

@andrewsykim

This comment has been minimized.

Copy link
Member Author

@andrewsykim andrewsykim commented Nov 8, 2019

/area dependency code-organization
/sig architecture

@andrewsykim

This comment has been minimized.

Copy link
Member Author

@andrewsykim andrewsykim commented Nov 8, 2019

/sig network

@athenabot

This comment has been minimized.

Copy link

@athenabot athenabot commented Nov 8, 2019

/triage unresolved

Comment /remove-triage unresolved when the issue is assessed and confirmed.

🤖 I am a bot run by vllry. 👩‍🔬

@andrewsykim

This comment has been minimized.

Copy link
Member Author

@andrewsykim andrewsykim commented Nov 8, 2019

/remove-triage unresolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.