Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource with non-expired endpoint may be marked as deleted resource #85765

Open
tedyu opened this issue Nov 30, 2019 · 1 comment

Comments

@tedyu
Copy link
Contributor

@tedyu tedyu commented Nov 30, 2019

What happened:
For ManagerImpl#GetCapacity, it is only called in test code.

This func removes resource from endpoints map when either one healthy or one unhealthy device has grace period expired.
This would result in resource having an expired unhealthy device and one non-expired healthy device to be removed from endpoints map.

What you expected to happen:
ManagerImpl#GetCapacity should be called in non-test code.

Secondly resource having an expired unhealthy device and one non-expired healthy device shouldn't be removed from endpoints map.

How to reproduce it (as minimally and precisely as possible):

Environment:

  • Kubernetes version (use kubectl version):
  • Cloud provider or hardware configuration:
  • OS (e.g: cat /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Network plugin and version (if this is a network-related bug):
  • Others:
@tedyu tedyu added the kind/bug label Nov 30, 2019
@tedyu

This comment has been minimized.

Copy link
Contributor Author

@tedyu tedyu commented Nov 30, 2019

/sig node

/cc @jiayingz

@k8s-ci-robot k8s-ci-robot added sig/node and removed needs-sig labels Nov 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.