Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework Migration Phase 2 #85822

Open
ahg-g opened this issue Dec 2, 2019 · 7 comments
Assignees
Milestone

Comments

@ahg-g
Copy link
Member

@ahg-g ahg-g commented Dec 2, 2019

This is an umbrella issue to track Phase 2 of the migration plan as discussed in the migration doc.

The main goal of Phase 2 is to deprecate predicates and priorities logic in the scheduler. We will keep supporting the Policy API (defines the scheduler behavior in terms of predicates and priorities), which will be supported through the policy-to-framework translation layer we built in Phase 1.

Important: please wait until a corresponding issue is created for each of the tasks below, we need to go through a careful evaluation of whether those tasks actually make sense and divide each one to perhaps a larger number of smaller tasks.

The high-level tasks are:

  • 1. Define algorithm providers in terms of plugins instead of predicates/priorities.
  • 2. Remove priorities execution path in schedule core (#85917).
  • 3. Remove predicates execution path in scheduler core (#85918).
  • 4. Break priority metadata computation into post-filter plugins (#85924).
    • 4.1 Move Affinity Priority Metadata calculation to a post-filter plugin (#85928)
    • 4.2 Move EvenPodSpread Priority Metadata calculation to a post-filter plugin (#85927)
  • 5. Break predicate metadata computation into pre-filter plugins.
    • 5.1 Move Affinity Predicate Metadata calculation to a pre-filter plugin (#85926)
    • 5.2 Move EvenPodSpread Predicate Metadata calculation to a pre-filter plugin (#85925)
  • 6. Move all predicates logic to their corresponding plugins.
  • 7. Move all priorities logic to their corresponding plugins.

/cc @alculquicondor @liu-cong @Huang-Wei @ravisantoshgudimetla @damemi

@ahg-g

This comment has been minimized.

Copy link
Member Author

@ahg-g ahg-g commented Dec 2, 2019

/sig scheduling
/assign

@Huang-Wei

This comment has been minimized.

Copy link
Member

@Huang-Wei Huang-Wei commented Dec 2, 2019

Break priority metadata computation into post-filter plugins.
Break predicate metadata computation into pre-filter plugins.

I will send PRs on EvenPodsSpread to resolve part of the above items.

@danielqsj

This comment has been minimized.

Copy link
Member

@danielqsj danielqsj commented Dec 3, 2019

/cc

2 similar comments
@SataQiu

This comment has been minimized.

Copy link
Member

@SataQiu SataQiu commented Dec 3, 2019

/cc

@zouyee

This comment has been minimized.

Copy link
Member

@zouyee zouyee commented Dec 3, 2019

/cc

@ahg-g

This comment has been minimized.

Copy link
Member Author

@ahg-g ahg-g commented Dec 5, 2019

/cc @wgliang

Thanks all for the interest, we will first do the perp work (tasks 1 - 5), and then I will create sub tasks for items 6 and 7 for anyone to contribute.

@ahg-g

This comment has been minimized.

Copy link
Member Author

@ahg-g ahg-g commented Dec 5, 2019

/milestone v1.18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.