Fix internal loadbalancer configuration failure when subnet name too long #86276

yangl900 · 2019-12-14T23:57:41Z

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind bug

/kind cleanup
/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
This PR fixes the mentioned issue and added new test coverage. The issue is that when subnet name is too long, cloud provider will use a long name for frontend IP configuration and load balancing rule name, which may exceed the 80 charactor limit.

Which issue(s) this PR fixes:

Fixes #86275

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Fix internal loadbalancer configuration failure when subnet name too long

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

k8s-ci-robot · 2019-12-14T23:57:45Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: login-issues@jira.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot · 2019-12-14T23:57:49Z

Welcome @yangl900!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2019-12-14T23:57:49Z

Hi @yangl900. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

yangl900 · 2019-12-15T00:02:52Z

/assign @andyzhangx

andyzhangx · 2019-12-15T02:26:17Z

/ok-to-test
/sig cloud-provider
/area provider/azure

andyzhangx · 2019-12-15T02:57:56Z

--- FAIL: TestgetFrontendIPConfigName (0.00s)
    azure_standard_test.go:407:

andyzhangx · 2019-12-15T03:26:07Z

staging/src/k8s.io/legacy-cloud-providers/azure/azure_standard.go

+		ipcName := fmt.Sprintf("%s-%s", baseName, *subnetName)
+
+		// Azure lb front end configuration name must not exceed 80 charactors
+		if len(ipcName) > 80 {


there are two places referencing num 80, pls define a const

defined 2 constants for rule name max length and ip config name max length.

andyzhangx · 2019-12-15T03:30:20Z

staging/src/k8s.io/legacy-cloud-providers/azure/azure_standard.go

+		subnetSegment = subnetSegment[:79 - len(ruleName)]
+	}
+
+	return fmt.Sprintf("%s-%s-%s-%d", prefix, subnetSegment, protocol, port)


is it possible that returned length of LoadBalancerRuleName exceeds 80?

that's not possible, the length of prefix + protocol + port has been calculated at len(ruleName). And based on how we calculate, it won't exceed 80 at that time, because UID is 36 characters - 4 hythen + 1 'a' at begining, it's 33 characters. with ports and protocol, it's well below 80.

at L287 we use the rule name length to truncate it to 80.

it won't since the subnetSegment has been truncated at L289

feiskyer · 2019-12-15T06:46:49Z

staging/src/k8s.io/legacy-cloud-providers/azure/azure_loadbalancer.go

@@ -405,7 +405,7 @@ func (az *Cloud) getServiceLoadBalancerStatus(service *v1.Service, lb *network.L
 		return nil, nil
 	}
 	isInternal := requiresInternalLoadBalancer(service)
-	lbFrontendIPConfigName := az.getFrontendIPConfigName(service, subnet(service))


thanks for cleanup this.

feiskyer · 2019-12-15T06:50:09Z

staging/src/k8s.io/legacy-cloud-providers/azure/azure_standard.go

+		subnetSegment = subnetSegment[:79 - len(ruleName)]
+	}
+
+	return fmt.Sprintf("%s-%s-%s-%d", prefix, subnetSegment, protocol, port)


it won't since the subnetSegment has been truncated at L289

feiskyer · 2019-12-15T06:50:51Z

/priority important-soon

yangl900

addressed the test failure and comments, please take a look again.

yangl900 · 2019-12-15T06:35:09Z

staging/src/k8s.io/legacy-cloud-providers/azure/azure_standard.go

+		subnetSegment = subnetSegment[:79 - len(ruleName)]
+	}
+
+	return fmt.Sprintf("%s-%s-%s-%d", prefix, subnetSegment, protocol, port)


that's not possible, the length of prefix + protocol + port has been calculated at len(ruleName). And based on how we calculate, it won't exceed 80 at that time, because UID is 36 characters - 4 hythen + 1 'a' at begining, it's 33 characters. with ports and protocol, it's well below 80.

at L287 we use the rule name length to truncate it to 80.

feiskyer · 2019-12-15T06:52:23Z

/test pull-kubernetes-e2e-aks-engine-azure
/test pull-kubernetes-e2e-azure-disk-vmss

yangl900 · 2019-12-15T07:32:24Z

/retest

andyzhangx

/lgtm
/test pull-kubernetes-e2e-aks-engine-azure
/test pull-kubernetes-e2e-azure-disk-vmss

feiskyer · 2019-12-16T02:23:57Z

/retest

feiskyer

/lgtm
/approve

k8s-ci-robot · 2019-12-16T02:31:35Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, yangl900

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~staging/src/k8s.io/legacy-cloud-providers/azure/OWNERS~~ [feiskyer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

yangl900 · 2019-12-16T04:48:00Z

/test pull-kubernetes-e2e-gce

feiskyer · 2019-12-16T05:32:54Z

/retest

yangl900 · 2019-12-16T06:56:06Z

flaky test issue #83870

yangl900 · 2019-12-16T06:56:22Z

/test pull-kubernetes-e2e-gce-100-performance

…76-upstream-release-1.17 Automated cherry pick of #86276: fix: should truncate long subnet name on lb rules

…76-upstream-release-1.16 Automated cherry pick of #86276: fix: should truncate long subnet name on lb rules

yangl900 added 2 commits December 13, 2019 23:27

fix: should truncate long subnet name on lb rules

1a55d0f

fix: add unit tests for truncate long subnet name on lb ip configuration

c6a2c4f

k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. labels Dec 14, 2019

k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 14, 2019

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 14, 2019

k8s-ci-robot requested review from justaugustus and khenidak December 14, 2019 23:58

k8s-ci-robot added area/cloudprovider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 14, 2019

k8s-ci-robot assigned andyzhangx Dec 15, 2019

andyzhangx reviewed Dec 15, 2019

View reviewed changes

fix: address test failure and review comments

d7f14fb

feiskyer reviewed Dec 15, 2019

View reviewed changes

k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 15, 2019

yangl900 commented Dec 15, 2019

View reviewed changes

fix: formating and typo

fbe3521

andyzhangx approved these changes Dec 15, 2019

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 15, 2019

feiskyer reviewed Dec 16, 2019

View reviewed changes

k8s-ci-robot assigned feiskyer Dec 16, 2019

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 16, 2019

k8s-ci-robot merged commit e680ad7 into kubernetes:master Dec 16, 2019

k8s-ci-robot added this to the v1.18 milestone Dec 16, 2019

liggitt mentioned this pull request Dec 16, 2019

[Flaky Test] [sig-storage] PersistentVolumes GCEPD should test that deleting the Namespace of a PVC and Pod causes the successful detach of Persistent Disk #86181

Closed

feiskyer mentioned this pull request Jan 24, 2020

Should limit the LoadBalancing rule's resource name length less than 80 characters long kubernetes/cloud-provider#41

Closed

feiskyer mentioned this pull request May 26, 2020

Automated cherry pick of #86276: fix: should truncate long subnet name on lb rules #91428

Merged

k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels May 26, 2020

feiskyer mentioned this pull request May 26, 2020

Automated cherry pick of #86276: fix: should truncate long subnet name on lb rules #91429

Merged

k8s-ci-robot added a commit that referenced this pull request May 31, 2020

Merge pull request #91428 from feiskyer/automated-cherry-pick-of-#862…

8885823

…76-upstream-release-1.17 Automated cherry pick of #86276: fix: should truncate long subnet name on lb rules

k8s-ci-robot added a commit that referenced this pull request May 31, 2020

Merge pull request #91429 from feiskyer/automated-cherry-pick-of-#862…

68ccd2e

…76-upstream-release-1.16 Automated cherry pick of #86276: fix: should truncate long subnet name on lb rules

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix internal loadbalancer configuration failure when subnet name too long #86276

Fix internal loadbalancer configuration failure when subnet name too long #86276

yangl900 commented Dec 14, 2019 •

edited by feiskyer

k8s-ci-robot commented Dec 14, 2019

k8s-ci-robot commented Dec 14, 2019

k8s-ci-robot commented Dec 14, 2019

yangl900 commented Dec 15, 2019

andyzhangx commented Dec 15, 2019

andyzhangx commented Dec 15, 2019

andyzhangx Dec 15, 2019

yangl900 Dec 15, 2019

andyzhangx Dec 15, 2019

yangl900 Dec 15, 2019

feiskyer Dec 15, 2019

feiskyer Dec 15, 2019

feiskyer Dec 15, 2019

feiskyer commented Dec 15, 2019

yangl900 left a comment

yangl900 Dec 15, 2019

feiskyer commented Dec 15, 2019

yangl900 commented Dec 15, 2019

andyzhangx left a comment

feiskyer commented Dec 16, 2019

feiskyer left a comment

k8s-ci-robot commented Dec 16, 2019

yangl900 commented Dec 16, 2019

feiskyer commented Dec 16, 2019

yangl900 commented Dec 16, 2019

yangl900 commented Dec 16, 2019

Fix internal loadbalancer configuration failure when subnet name too long #86276

Fix internal loadbalancer configuration failure when subnet name too long #86276

Conversation

yangl900 commented Dec 14, 2019 • edited by feiskyer

k8s-ci-robot commented Dec 14, 2019

k8s-ci-robot commented Dec 14, 2019

k8s-ci-robot commented Dec 14, 2019

yangl900 commented Dec 15, 2019

andyzhangx commented Dec 15, 2019

andyzhangx commented Dec 15, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

feiskyer commented Dec 15, 2019

yangl900 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

feiskyer commented Dec 15, 2019

yangl900 commented Dec 15, 2019

andyzhangx left a comment

Choose a reason for hiding this comment

feiskyer commented Dec 16, 2019

feiskyer left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Dec 16, 2019

yangl900 commented Dec 16, 2019

feiskyer commented Dec 16, 2019

yangl900 commented Dec 16, 2019

yangl900 commented Dec 16, 2019

yangl900 commented Dec 14, 2019 •

edited by feiskyer