Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move VolumeZone predicate to its Filter plugin #86623

Merged
merged 1 commit into from Dec 26, 2019
Merged

Move VolumeZone predicate to its Filter plugin #86623

merged 1 commit into from Dec 26, 2019

Conversation

zouyee
Copy link
Member

@zouyee zouyee commented Dec 26, 2019 •
edited

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Move VolumeZone predicate to its Filter plugin

Which issue(s) this PR fixes:

Fixes #86444

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 26, 2019
@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 26, 2019
@zouyee
Copy link
Member Author

zouyee commented Dec 26, 2019

/assign @ahg-g

ahg-g
ahg-g reviewed Dec 26, 2019
View reviewed changes
Copy link
Member

@ahg-g ahg-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

pkg/scheduler/framework/plugins/volumezone/volume_zone.go Outdated
Comment on lines 157 to 159
status := framework.NewStatus(framework.UnschedulableAndUnresolvable)
status.AppendReason(predicates.ErrVolumeZoneConflict.GetReason())
return status
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replace the lines above with return framework.NewStatus(framework.UnschedulableAndUnresolvable, predicates.ErrVolumeZoneConflict.GetReason())

pkg/scheduler/framework/plugins/volumezone/volume_zone.go Outdated
return nil
}
namespace := pod.Namespace
manifest := &(pod.Spec)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this line please and just use pod.Spec directly in the lines below

pkg/scheduler/framework/plugins/volumezone/volume_zone.go Outdated
// We want to fast-path this case though.
return nil
}
namespace := pod.Namespace
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this and just use pod.Namespace directly below.

@ahg-g
Copy link
Member

ahg-g commented Dec 26, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 26, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, zouyee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 26, 2019
@ahg-g
Copy link
Member

ahg-g commented Dec 26, 2019

/hold
Until #86614 is merged

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 26, 2019
Move VolumeZone predicate to its Filter plugin
c4331b0 
Signed-off-by: Zou Nengren <zouyee1989@gmail.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 26, 2019
@ahg-g
Copy link
Member

ahg-g commented Dec 26, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 26, 2019
@ahg-g
Copy link
Member

ahg-g commented Dec 26, 2019

/retest

@ahg-g
Copy link
Member

ahg-g commented Dec 26, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 26, 2019
@ahg-g
Copy link
Member

ahg-g commented Dec 26, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit 75bcc9d into kubernetes:master Dec 26, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Dec 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahg-g ahg-g ahg-g left review comments

@alculquicondor alculquicondor Awaiting requested review from alculquicondor

@hex108 hex108 Awaiting requested review from hex108

Assignees

@ahg-g ahg-g

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

Move VolumeZone predicate to its Filter plugin [Migration Phase 2]
3 participants
@zouyee @ahg-g @k8s-ci-robot