Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
SchedulerPredicates [Serial] validates resource limits of pods that are allowed to run - possibly invalid test #87191
I am questioning validity of the test. Comments under
The test scenario described as it is sounds reasonable. The only nitpick I have is the very first sentence saying "
In the framework:
The test is alternating between passing and failing state. It passes when predicates give empty list of candidate nodes and failing when the list of candidate nodes is non-empty. Thus, making the pod resource limits ineffective.
What you expected to happen:
Have another node schedule the additional pod validating that all saturated nodes (with
Can anyone check the test validity and confirm/disprove my statement about ineffectiveness of the resource limits?
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?: