Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate pod creation methods in storage testsuites #88058

Open
msau42 opened this issue Feb 12, 2020 · 2 comments · May be fixed by #88218
Open

Consolidate pod creation methods in storage testsuites #88058

msau42 opened this issue Feb 12, 2020 · 2 comments · May be fixed by #88218

Comments

@msau42
Copy link
Member

@msau42 msau42 commented Feb 12, 2020

What would you like to be added:
As seen in #88054, there are many different ways the storage testsuites create pod objects. It would be nice to consolidate all the different methods into one common pod creation util, like e2epod.MakeSecPod, so that all the tests will automatically support setting fsgroup, selinux, node affinity, etc.

I think this can be tackled in a few distinct tasks:

  • Improve the interface for MakeSecPod. It is really unwieldy to read right now with 10+ arguments. It should probably be a refactored into an argument struct. I think we can rename it as well; I'm not sure what the "Sec" really means.
  • Move SetNodeSelection into MakeSecPod so that every test doesn't have to set it.
  • Migrate individual test suites one by one to use MakeSecPod

/help
@kubernetes/sig-storage-misc

@msau42 msau42 added the kind/feature label Feb 12, 2020
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Feb 12, 2020

@msau42:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

What would you like to be added:
As seen in #88054, there are many different ways the storage testsuites create pod objects. It would be nice to consolidate all the different methods into one common pod creation util, like e2epod.MakeSecPod, so that all the tests will automatically support setting fsgroup, selinux, node affinity, etc.

I think this can be tackled in a few distinct tasks:

  • Improve the interface for MakeSecPod. It is really unwieldy to read right now with 10+ arguments. It should probably be a refactored into an argument struct. I think we can rename it as well; I'm not sure what the "Sec" really means.
  • Move SetNodeSelection into MakeSecPod so that every test doesn't have to set it.
  • Migrate individual test suites one by one to use MakeSecPod

/help
@kubernetes/sig-storage-misc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gavinfish

This comment has been minimized.

Copy link
Contributor

@gavinfish gavinfish commented Feb 12, 2020

/cc

@SomtochiAma SomtochiAma linked a pull request that will close this issue Feb 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants
You can’t perform that action at this time.